-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canary build of packages using CodeSandbox CI + mini repl #11479
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21304/ |
@@ -1,5 +1,6 @@ | |||
{ | |||
"installCommand": "bootstrap", | |||
"installCommand": "codesandbox", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just run build
? The build-no-bundle
run babel
on every package while build
will rollup babel-parsers
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that build
was too slow and froze codesandbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we purposely didn't because we don't need it in this case, and it was too slow for some reason: https://ci.codesandbox.io/status/hzoo/babel/pr/1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it comes from building babel-standalone
.
An ugly workaround is BABEL_COVERAGE=true make bootstrap
, which will skip building standalone.
Henry, do you remember that thing about ✔️s before merging PRs? 😛 Anyway, consider me as having approved this! |
Oh yeah I was assuming that, but noted 👍 |
Done with @nicolo-ribaudo! Got to learn more about Next, CodeSandbox, babel-standalone 😄
Current Babel template (forked @CompuIves one in #10639): https://codesandbox.io/s/babel-repl-9d0wg
cc @CompuIves
Integrating this got me thinking about some feature requests: