Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary build of packages using CodeSandbox CI + mini repl #11479

Merged
merged 4 commits into from Apr 24, 2020
Merged

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Apr 24, 2020

Done with @nicolo-ribaudo! Got to learn more about Next, CodeSandbox, babel-standalone 馃槃

Did some tests earlier on local fork hzoo#3

Current Babel template (forked @CompuIves one in #10639): https://codesandbox.io/s/babel-repl-9d0wg

  • not using babel-standalone since I don't want to bundle (takes too long), so it just publishes the built files
  • we just manually required all the plugins/presets so they are available

cc @CompuIves

Integrating this got me thinking about some feature requests:

  • being able to change the codesandbox bot comment
  • can you programmatically generate templates based on the PR

@hzoo hzoo added PR: Internal 馃彔 A type of pull request used for our changelog categories repo automation 馃 labels Apr 24, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21304/

@@ -1,5 +1,6 @@
{
"installCommand": "bootstrap",
"installCommand": "codesandbox",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just run build? The build-no-bundle run babel on every package while build will rollup babel-parsers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that build was too slow and froze codesandbox

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we purposely didn't because we don't need it in this case, and it was too slow for some reason: https://ci.codesandbox.io/status/hzoo/babel/pr/1

Copy link
Contributor

@JLHwung JLHwung Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it comes from building babel-standalone.

An ugly workaround is BABEL_COVERAGE=true make bootstrap, which will skip building standalone.

@hzoo hzoo changed the title Canary build of packages using CodeSandbox CI Canary build of packages using CodeSandbox CI + mini repl Apr 24, 2020
@hzoo hzoo merged commit e010db8 into babel:master Apr 24, 2020
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Apr 24, 2020

Henry, do you remember that thing about 鉁旓笍s before merging PRs? 馃槢

Anyway, consider me as having approved this!

@hzoo
Copy link
Member Author

hzoo commented Apr 24, 2020

Oh yeah I was assuming that, but noted 馃憤

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2020
@hzoo hzoo deleted the repl branch August 27, 2020 00:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 馃彔 A type of pull request used for our changelog categories repo automation 馃
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants