Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canary build of packages using CodeSandbox CI + mini repl #11479

Merged
merged 4 commits into from Apr 24, 2020
Merged

Canary build of packages using CodeSandbox CI + mini repl #11479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ecaf957
Update package.json
hzoo Apr 24, 2020
0d46bbd
Update ci.json
hzoo Apr 24, 2020
ddef1af
Update ci.json
hzoo Apr 24, 2020
2107753
Update ci.json
hzoo Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions .codesandbox/ci.json
View file
Open in desktop
@@ -1,5 +1,6 @@
{
"installCommand": "bootstrap",
"installCommand": "codesandbox",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just run build? The build-no-bundle run babel on every package while build will rollup babel-parsers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that build was too slow and froze codesandbox

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we purposely didn't because we don't need it in this case, and it was too slow for some reason: https://ci.codesandbox.io/status/hzoo/babel/pr/1

Copy link
Contributor

@JLHwung JLHwung Apr 24, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it comes from building babel-standalone.

An ugly workaround is BABEL_COVERAGE=true make bootstrap, which will skip building standalone.

"buildCommand": false,
"sandboxes": ["kypop"]
"sandboxes": ["9d0wg"],
"packages": ["packages/*"]
}
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@
"license": "MIT",
"scripts": {
"bootstrap": "make bootstrap",
"codesandbox": "make bootstrap-only; make build-no-bundle",
"build": "make build",
"fix": "make fix",
"lint": "make lint",
Expand Down