Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for privateMap's existence #11571

Merged
merged 8 commits into from May 30, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -182,8 +182,8 @@ export function createClassFeaturePlugin({
}

path = wrapClass(path);
path.insertBefore(keysNodes);
path.insertAfter([...privateNamesNodes, ...staticNodes]);
path.insertBefore([...privateNamesNodes, ...keysNodes]);
path.insertAfter(staticNodes);
},

PrivateName(path) {
Expand Down
@@ -1,12 +1,12 @@
var _privateMethod = new WeakSet();

class X {
constructor() {
_privateMethod.add(this);
}

}

var _privateMethod = new WeakSet();

var _privateMethod2 = function _privateMethod2() {
return 42;
};
Expand Up @@ -2,6 +2,8 @@ var id = 0;

function _classPrivateFieldLooseKey(name) { return "__private_" + id++ + "_" + name; }

var _privateMethod = _classPrivateFieldLooseKey("privateMethod");

class X {
constructor() {
Object.defineProperty(this, _privateMethod, {
Expand All @@ -11,8 +13,6 @@ class X {

}

var _privateMethod = _classPrivateFieldLooseKey("privateMethod");

var _privateMethod2 = function _privateMethod2() {
return 42;
};
@@ -1,3 +1,5 @@
var _foo = babelHelpers.classPrivateFieldLooseKey("foo");

var Foo = /*#__PURE__*/function () {
"use strict";

Expand All @@ -20,5 +22,3 @@ var Foo = /*#__PURE__*/function () {
}]);
return Foo;
}();

var _foo = babelHelpers.classPrivateFieldLooseKey("foo");
@@ -1,3 +1,5 @@
var _foo = babelHelpers.classPrivateFieldLooseKey("foo");

var Foo = /*#__PURE__*/function () {
"use strict";

Expand All @@ -21,5 +23,3 @@ var Foo = /*#__PURE__*/function () {
}]);
return Foo;
}();

var _foo = babelHelpers.classPrivateFieldLooseKey("foo");
@@ -1,3 +1,7 @@
var _x = babelHelpers.classPrivateFieldLooseKey("x");

var _y = babelHelpers.classPrivateFieldLooseKey("y");

var Point = /*#__PURE__*/function () {
"use strict";

Expand Down Expand Up @@ -44,7 +48,3 @@ var Point = /*#__PURE__*/function () {
}]);
return Point;
}();

var _x = babelHelpers.classPrivateFieldLooseKey("x");

var _y = babelHelpers.classPrivateFieldLooseKey("y");
@@ -1,5 +1,7 @@
var foo = "bar";

var _bar = babelHelpers.classPrivateFieldLooseKey("bar");

var Foo = function Foo() {
"use strict";

Expand All @@ -10,5 +12,3 @@ var Foo = function Foo() {
});
var _foo = "foo";
};

var _bar = babelHelpers.classPrivateFieldLooseKey("bar");
@@ -1,3 +1,5 @@
var _x = babelHelpers.classPrivateFieldLooseKey("x");

var C = function C() {
"use strict";

Expand All @@ -9,8 +11,6 @@ var C = function C() {
});
};

var _x = babelHelpers.classPrivateFieldLooseKey("x");

expect(() => {
new C();
}).toThrow();
@@ -1,3 +1,5 @@
var _bar = babelHelpers.classPrivateFieldLooseKey("bar");

var Foo = /*#__PURE__*/function (_Bar) {
"use strict";

Expand Down Expand Up @@ -29,5 +31,3 @@ var Foo = /*#__PURE__*/function (_Bar) {

return Foo;
}(Bar);

var _bar = babelHelpers.classPrivateFieldLooseKey("bar");
@@ -1,3 +1,5 @@
var _prop = babelHelpers.classPrivateFieldLooseKey("prop");

var Foo = function Foo() {
"use strict";

Expand All @@ -8,7 +10,7 @@ var Foo = function Foo() {
});
};

var _prop = babelHelpers.classPrivateFieldLooseKey("prop");
var _prop2 = babelHelpers.classPrivateFieldLooseKey("prop");

var Bar = /*#__PURE__*/function (_Foo) {
"use strict";
Expand All @@ -31,5 +33,3 @@ var Bar = /*#__PURE__*/function (_Foo) {

return Bar;
}(Foo);

var _prop2 = babelHelpers.classPrivateFieldLooseKey("prop");
@@ -1,3 +1,5 @@
var _client = babelHelpers.classPrivateFieldLooseKey("client");

var Foo = function Foo(props) {
"use strict";

Expand All @@ -9,5 +11,3 @@ var Foo = function Foo(props) {
babelHelpers.classPrivateFieldLooseBase(this, _client)[_client] = 1;
[this.x = babelHelpers.classPrivateFieldLooseBase(this, _client)[_client], babelHelpers.classPrivateFieldLooseBase(this, _client)[_client], this.y = babelHelpers.classPrivateFieldLooseBase(this, _client)[_client]] = props;
};

var _client = babelHelpers.classPrivateFieldLooseKey("client");
@@ -1,3 +1,5 @@
var _client = babelHelpers.classPrivateFieldLooseKey("client");

var Foo = function Foo(props) {
"use strict";

Expand All @@ -8,5 +10,3 @@ var Foo = function Foo(props) {
});
[x, ...babelHelpers.classPrivateFieldLooseBase(this, _client)[_client]] = props;
};

var _client = babelHelpers.classPrivateFieldLooseKey("client");
@@ -1,3 +1,5 @@
var _client = babelHelpers.classPrivateFieldLooseKey("client");

var Foo = function Foo(props) {
"use strict";

Expand All @@ -8,5 +10,3 @@ var Foo = function Foo(props) {
});
[babelHelpers.classPrivateFieldLooseBase(this, _client)[_client] = 5] = props;
};

var _client = babelHelpers.classPrivateFieldLooseKey("client");
@@ -1,3 +1,5 @@
var _client = babelHelpers.classPrivateFieldLooseKey("client");

var Foo = function Foo(props) {
"use strict";

Expand All @@ -8,5 +10,3 @@ var Foo = function Foo(props) {
});
[babelHelpers.classPrivateFieldLooseBase(this, _client)[_client]] = props;
};

var _client = babelHelpers.classPrivateFieldLooseKey("client");
@@ -1,3 +1,5 @@
var _client = babelHelpers.classPrivateFieldLooseKey("client");

var Foo = function Foo(props) {
"use strict";

Expand All @@ -13,5 +15,3 @@ var Foo = function Foo(props) {
z: this.z = babelHelpers.classPrivateFieldLooseBase(this, _client)[_client]
} = props);
};

var _client = babelHelpers.classPrivateFieldLooseKey("client");
@@ -1,3 +1,5 @@
var _client = babelHelpers.classPrivateFieldLooseKey("client");

var Foo = function Foo(props) {
"use strict";

Expand All @@ -11,5 +13,3 @@ var Foo = function Foo(props) {
...babelHelpers.classPrivateFieldLooseBase(this, _client)[_client]
} = props);
};

var _client = babelHelpers.classPrivateFieldLooseKey("client");
@@ -1,3 +1,5 @@
var _client = babelHelpers.classPrivateFieldLooseKey("client");

var Foo = function Foo(props) {
"use strict";

Expand All @@ -10,5 +12,3 @@ var Foo = function Foo(props) {
client: babelHelpers.classPrivateFieldLooseBase(this, _client)[_client] = 5
} = props);
};

var _client = babelHelpers.classPrivateFieldLooseKey("client");
@@ -1,3 +1,5 @@
var _client = babelHelpers.classPrivateFieldLooseKey("client");

var Foo = function Foo(props) {
"use strict";

Expand All @@ -10,5 +12,3 @@ var Foo = function Foo(props) {
client: babelHelpers.classPrivateFieldLooseBase(this, _client)[_client]
} = props);
};

var _client = babelHelpers.classPrivateFieldLooseKey("client");
@@ -1,5 +1,9 @@
var foo = "bar";

var _bar = babelHelpers.classPrivateFieldLooseKey("bar");

var _baz = babelHelpers.classPrivateFieldLooseKey("baz");

var Foo = function Foo(_foo) {
"use strict";

Expand All @@ -13,7 +17,3 @@ var Foo = function Foo(_foo) {
value: foo
});
};

var _bar = babelHelpers.classPrivateFieldLooseKey("bar");

var _baz = babelHelpers.classPrivateFieldLooseKey("baz");
@@ -1,3 +1,5 @@
var _scopedFunctionWithThis = babelHelpers.classPrivateFieldLooseKey("scopedFunctionWithThis");

var Child = /*#__PURE__*/function (_Parent) {
"use strict";

Expand All @@ -21,5 +23,3 @@ var Child = /*#__PURE__*/function (_Parent) {

return Child;
}(Parent);

var _scopedFunctionWithThis = babelHelpers.classPrivateFieldLooseKey("scopedFunctionWithThis");
@@ -1,3 +1,5 @@
var _bar = babelHelpers.classPrivateFieldLooseKey("bar");

var Foo = function Foo() {
"use strict";

Expand All @@ -7,5 +9,3 @@ var Foo = function Foo() {
value: void 0
});
};

var _bar = babelHelpers.classPrivateFieldLooseKey("bar");
@@ -1,3 +1,5 @@
var _bar = babelHelpers.classPrivateFieldLooseKey("bar");

var Foo = function Foo() {
"use strict";

Expand All @@ -7,5 +9,3 @@ var Foo = function Foo() {
value: "foo"
});
};

var _bar = babelHelpers.classPrivateFieldLooseKey("bar");
@@ -1,3 +1,7 @@
var _x = babelHelpers.classPrivateFieldLooseKey("x");

var _y = babelHelpers.classPrivateFieldLooseKey("y");

var Foo = function Foo() {
"use strict";

Expand All @@ -11,7 +15,3 @@ var Foo = function Foo() {
value: babelHelpers.classPrivateFieldLooseBase(this, _x)[_x]
});
};

var _x = babelHelpers.classPrivateFieldLooseKey("x");

var _y = babelHelpers.classPrivateFieldLooseKey("y");
@@ -1,3 +1,7 @@
var _foo = babelHelpers.classPrivateFieldLooseKey("foo");

var _bar = babelHelpers.classPrivateFieldLooseKey("bar");

class Foo {
constructor() {
Object.defineProperty(this, _bar, {
Expand All @@ -16,10 +20,6 @@ class Foo {

}

var _foo = babelHelpers.classPrivateFieldLooseKey("foo");

var _bar = babelHelpers.classPrivateFieldLooseKey("bar");

Object.defineProperty(Foo, _foo, {
writable: true,
value: "foo"
Expand Down
@@ -1,3 +1,5 @@
var _foo = babelHelpers.classPrivateFieldLooseKey("foo");

var Foo = /*#__PURE__*/function () {
"use strict";

Expand All @@ -14,6 +16,8 @@ var Foo = /*#__PURE__*/function () {
value: function test() {
var _babelHelpers$classPr;

var _foo2 = babelHelpers.classPrivateFieldLooseKey("foo");

_babelHelpers$classPr = babelHelpers.classPrivateFieldLooseBase(this, _foo2)[_foo2];

var Nested = /*#__PURE__*/function () {
Expand All @@ -32,12 +36,8 @@ var Foo = /*#__PURE__*/function () {
return Nested;
}();

var _foo2 = babelHelpers.classPrivateFieldLooseKey("foo");

babelHelpers.classPrivateFieldLooseBase(this, _foo)[_foo];
}
}]);
return Foo;
}();

var _foo = babelHelpers.classPrivateFieldLooseKey("foo");
@@ -1,3 +1,5 @@
var _foo = babelHelpers.classPrivateFieldLooseKey("foo");

var Foo = /*#__PURE__*/function () {
"use strict";

Expand Down Expand Up @@ -31,5 +33,3 @@ var Foo = /*#__PURE__*/function () {
}]);
return Foo;
}();

var _foo = babelHelpers.classPrivateFieldLooseKey("foo");