chore: build standalone once in prepublish step #11777
Merged
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f07ad4b:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/25051/ |
kaicataldo
approved these changes
Jul 1, 2020
JLHwung
force-pushed
the
build-minified-standalone-prepublish
branch
from
c92064e to
f07ad4b
Compare
|
✅ As we can see in https://app.circleci.com/pipelines/github/babel/babel/3237/workflows/0018a857-7362-4563-a44e-6da6443c9d07/jobs/25052 that the published |
Closed
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make publishCurrently when
make prepublishruns,@babel/standalonewill be built twicemake prepublish=>make build=>make build-standalonenpm run-script prepublishOnly=>make prepublish-build-standaloneThe first step skips minification while the second one includes it. This PR removes the
scriptshook in@babel/standaloneand runprepublish-build-standalonewhenprepublishrecipe is executed.