Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: build standalone once in prepublish step #11777

Merged
merged 1 commit into from Jul 30, 2020
Merged

chore: build standalone once in prepublish step #11777

merged 1 commit into from Jul 30, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 1, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Removed duplicate build-standalone step in make publish
License MIT

Currently when make prepublish runs, @babel/standalone will be built twice

  1. make prepublish => make build => make build-standalone
  2. npm run-script prepublishOnly => make prepublish-build-standalone

The first step skips minification while the second one includes it. This PR removes the scripts hook in @babel/standalone and run prepublish-build-standalone when prepublish recipe is executed.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jul 1, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 1, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f07ad4b:

Sandbox Source
stupefied-haibt-z7ses Configuration
beautiful-sound-1hcp2 Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 1, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/25051/

@JLHwung JLHwung force-pushed the build-minified-standalone-prepublish branch from c92064e to f07ad4b Compare July 1, 2020 21:08
@JLHwung
Copy link
Contributor Author

JLHwung commented Jul 30, 2020

✅ As we can see in https://app.circleci.com/pipelines/github/babel/babel/3237/workflows/0018a857-7362-4563-a44e-6da6443c9d07/jobs/25052 that the published @babel/standalone contains both minified and raw versions. This behaviour is not changed.

@JLHwung JLHwung merged commit 0e4cf1e into babel:main Jul 30, 2020
@JLHwung JLHwung deleted the build-minified-standalone-prepublish branch July 30, 2020 16:54
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Aug 14, 2020
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JLHwung @babel-bot @kaicataldo