Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always retain lines for async arrow #11836

Merged
merged 6 commits into from Jul 15, 2020
Merged

Always retain lines for async arrow #11836

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e5d9860
Always print params with parentheses for async arrow functions (#11830)
cwohlman Jul 13, 2020
3c886bc
Add a failing test for async arrow functions with comments
cwohlman Jul 14, 2020
bd218bb
Merge remote-tracking branch 'origin/suggested-fix-11830' into fix-11830
cwohlman Jul 14, 2020
63fadfa
Match test output to actual output
cwohlman Jul 14, 2020
eda47a8
Move check for node.async to retain lines instead of always print parens
cwohlman Jul 15, 2020
8cae946
Fix linting & tests for parentheses/async-arrow-function
cwohlman Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/babel-generator/src/generators/methods.js
View file
Open in desktop
Expand Up @@ -109,7 +109,8 @@ export function ArrowFunctionExpression(node: Object) {
if (
node.params.length === 1 &&
t.isIdentifier(firstParam) &&
!hasTypes(node, firstParam)
!hasTypes(node, firstParam) &&
!node.async
) {
if (
this.format.retainLines &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can move node.async to here

this.format.retainLines || node.async

so we are instructing that if async presents, we try to retain lines and print ( if the function body is in different lines with the async arrow.

Expand Down
10 changes: 10 additions & 0 deletions packages/babel-generator/test/fixtures/parentheses/async-arrow-function/input.js
View file
Open in desktop
@@ -0,0 +1,10 @@
const x = async (
// some comment
a
) => {
return foo(await a);
};

function foo(a) {
return a;
}
1 change: 1 addition & 0 deletions packages/babel-generator/test/fixtures/parentheses/async-arrow-function/options.json
View file
Open in desktop
@@ -0,0 +1 @@
{}
8 changes: 8 additions & 0 deletions packages/babel-generator/test/fixtures/parentheses/async-arrow-function/output.js
View file
Open in desktop
@@ -0,0 +1,8 @@
const x = async ( // some comment
a) => {
return foo(await a);
};

function foo(a) {
return a;
}