Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lodash 'isRegExp' usage with NodeJS util isRegExp (or a fallback when unavailable) #11856

Closed
wants to merge 18 commits into from
Closed

Replace lodash 'isRegExp' usage with NodeJS util isRegExp (or a fallback when unavailable) #11856

Changes from 5 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f8654f9
Replace lodash 'isRegExp' usage with is-regexp library
jayaddison Jul 20, 2020
62b8ae9
Assess isRegExp via NodeJS utils library where available, with string…
jayaddison Jul 30, 2020
50f7914
Add linebreaks for ternary condition
jayaddison Jul 31, 2020
43b08e2
Ensure arrow function is used unambiguously
jayaddison Jul 31, 2020
4cfd90b
Use double-quotes instead of single-quotes
jayaddison Jul 31, 2020
d25f092
Merge branch 'main' into dependencies/reduce-lodash-usage-isregexp
jayaddison Oct 15, 2020
51a7033
nodeUtilTypes check only needs to be performed once
jayaddison Oct 15, 2020
15365ff
Rewrite nodeUtilTypes check without optional chaining operator
jayaddison Oct 15, 2020
486b705
Avoid SyntaxError ambiguity regarding arrow function parameter list
jayaddison Oct 15, 2020
2815784
Apply linter fixes
jayaddison Oct 15, 2020
7e5bbb4
Fixup: one remaining lint cleanup
jayaddison Oct 15, 2020
926ddd1
Cleanup: brevity
jayaddison Oct 15, 2020
cbd5c9e
Static analysis: Add FlowIgnore statement with explanatory comment
jayaddison Oct 15, 2020
c39876a
Add Babel 8 todo note
jayaddison Oct 15, 2020
ed0537d
Refactor: remove use of try...catch block
jayaddison Oct 15, 2020
982ca4d
Clarify Babel 8 todo note
jayaddison Oct 15, 2020
081c22b
Merge branch 'main' into dependencies/reduce-lodash-usage-isregexp
jayaddison Nov 9, 2020
c4c2850
Merge branch 'main' into dependencies/reduce-lodash-usage-isregexp
jayaddison Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/babel-types/src/converters/valueToNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// @flow
import isPlainObject from "lodash/isPlainObject";
import isRegExp from "lodash/isRegExp";
import isValidIdentifier from "../validators/isValidIdentifier";
import {
identifier,
Expand All @@ -16,6 +15,18 @@ import {
binaryExpression,
} from "../builders/generated";

let nodeUtilTypes;
try {
const util = require("util");
nodeUtilTypes = util.types || util;
} catch {}

const isRegExp = value => {
return nodeUtilTypes
? nodeUtilTypes.isRegExp(value)
: Object.prototype.toString.call(value) === "[object RegExp]";
};
jayaddison marked this conversation as resolved.
Show resolved Hide resolved

export default function valueToNode(value: any): Object {
// undefined
if (value === undefined) {
Expand Down