Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect module path when absoluteRuntime is specified #11893

Merged
merged 5 commits into from Jul 30, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/babel-plugin-transform-runtime/src/index.js
Expand Up @@ -310,7 +310,7 @@ export default declare((api, options, dirname) => {
node.callee = t.memberExpression(
t.callExpression(
this.addDefaultImport(
`${moduleName}/${corejsRoot}/instance/${InstanceProperties[propertyName].path}`,
`${modulePath}/${corejsRoot}/instance/${InstanceProperties[propertyName].path}`,
`${propertyName}InstanceProperty`,
),
[context2],
Expand Down Expand Up @@ -379,7 +379,7 @@ export default declare((api, options, dirname) => {
path.replaceWith(
t.callExpression(
this.addDefaultImport(
`${moduleName}/core-js/get-iterator-method`,
`${modulePath}/core-js/get-iterator-method`,
"getIteratorMethod",
),
[object],
Expand Down Expand Up @@ -407,7 +407,7 @@ export default declare((api, options, dirname) => {
path.replaceWith(
t.callExpression(
this.addDefaultImport(
`${moduleName}/${corejsRoot}/instance/${InstanceProperties[propertyName].path}`,
`${modulePath}/${corejsRoot}/instance/${InstanceProperties[propertyName].path}`,
`${propertyName}InstanceProperty`,
),
[object],
Expand Down
@@ -0,0 +1,8 @@
Array.map;
function* makeIterator() {
yield 1;
yield 2;
}
for (const itItem of makeIterator()) {
console.log(itItem);
}
@@ -0,0 +1,6 @@
{
"presets": ["env"],
"plugins": [
["transform-runtime", { "absoluteRuntime": true, "corejs": { "version": 3, "proposals": true } }]
JLHwung marked this conversation as resolved.
Show resolved Hide resolved
]
}
@@ -0,0 +1,59 @@
var _getIterator = require("<CWD>/node_modules/@babel/runtime-corejs3/core-js/get-iterator");

var _Array$isArray = require("<CWD>/node_modules/@babel/runtime-corejs3/core-js/array/is-array");

var _getIteratorMethod = require("<CWD>/node_modules/@babel/runtime-corejs3/core-js/get-iterator-method");

var _Symbol = require("<CWD>/node_modules/@babel/runtime-corejs3/core-js/symbol");

var _Array$from = require("<CWD>/node_modules/@babel/runtime-corejs3/core-js/array/from");

var _sliceInstanceProperty = require("<CWD>/node_modules/@babel/runtime-corejs3/core-js/instance/slice");

var _regeneratorRuntime = require("<CWD>/node_modules/@babel/runtime-corejs3/regenerator");

var _mapInstanceProperty = require("<CWD>/node_modules/@babel/runtime-corejs3/core-js/instance/map");

function _createForOfIteratorHelper(o, allowArrayLike) { var it; if (typeof _Symbol === "undefined" || _getIteratorMethod(o) == null) { if (_Array$isArray(o) || (it = _unsupportedIterableToArray(o)) || allowArrayLike && o && typeof o.length === "number") { if (it) o = it; var i = 0; var F = function F() {}; return { s: F, n: function n() { if (i >= o.length) return { done: true }; return { done: false, value: o[i++] }; }, e: function e(_e) { throw _e; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var normalCompletion = true, didErr = false, err; return { s: function s() { it = _getIterator(o); }, n: function n() { var step = it.next(); normalCompletion = step.done; return step; }, e: function e(_e2) { didErr = true; err = _e2; }, f: function f() { try { if (!normalCompletion && it["return"] != null) it["return"](); } finally { if (didErr) throw err; } } }; }

function _unsupportedIterableToArray(o, minLen) { var _context2; if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = _sliceInstanceProperty(_context2 = Object.prototype.toString.call(o)).call(_context2, 8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return _Array$from(o); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); }

function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; }

var _marked = /*#__PURE__*/_regeneratorRuntime.mark(makeIterator);

_mapInstanceProperty(Array);

function makeIterator() {
return _regeneratorRuntime.wrap(function makeIterator$(_context) {
while (1) {
switch (_context.prev = _context.next) {
case 0:
_context.next = 2;
return 1;

case 2:
_context.next = 4;
return 2;

case 4:
case "end":
return _context.stop();
}
}
}, _marked);
}

var _iterator = _createForOfIteratorHelper(makeIterator()),
_step;

try {
for (_iterator.s(); !(_step = _iterator.n()).done;) {
var itItem = _step.value;
console.log(itItem);
}
} catch (err) {
_iterator.e(err);
} finally {
_iterator.f();
}
@@ -0,0 +1,8 @@
Array.map;
function* makeIterator() {
yield 1;
yield 2;
}
for (const itItem of makeIterator()) {
console.log(itItem);
}
@@ -0,0 +1,6 @@
{
"presets": ["env"],
"plugins": [
["transform-runtime", { "absoluteRuntime": true, "corejs": { "version": 3, "proposals": false } }]
JLHwung marked this conversation as resolved.
Show resolved Hide resolved
]
}
@@ -0,0 +1,59 @@
var _getIterator = require("<CWD>/node_modules/@babel/runtime-corejs3/core-js/get-iterator");

var _Array$isArray = require("<CWD>/node_modules/@babel/runtime-corejs3/core-js-stable/array/is-array");

var _getIteratorMethod = require("<CWD>/node_modules/@babel/runtime-corejs3/core-js/get-iterator-method");

var _Symbol = require("<CWD>/node_modules/@babel/runtime-corejs3/core-js-stable/symbol");

var _Array$from = require("<CWD>/node_modules/@babel/runtime-corejs3/core-js-stable/array/from");

var _sliceInstanceProperty = require("<CWD>/node_modules/@babel/runtime-corejs3/core-js-stable/instance/slice");

var _regeneratorRuntime = require("<CWD>/node_modules/@babel/runtime-corejs3/regenerator");

var _mapInstanceProperty = require("<CWD>/node_modules/@babel/runtime-corejs3/core-js-stable/instance/map");

function _createForOfIteratorHelper(o, allowArrayLike) { var it; if (typeof _Symbol === "undefined" || _getIteratorMethod(o) == null) { if (_Array$isArray(o) || (it = _unsupportedIterableToArray(o)) || allowArrayLike && o && typeof o.length === "number") { if (it) o = it; var i = 0; var F = function F() {}; return { s: F, n: function n() { if (i >= o.length) return { done: true }; return { done: false, value: o[i++] }; }, e: function e(_e) { throw _e; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var normalCompletion = true, didErr = false, err; return { s: function s() { it = _getIterator(o); }, n: function n() { var step = it.next(); normalCompletion = step.done; return step; }, e: function e(_e2) { didErr = true; err = _e2; }, f: function f() { try { if (!normalCompletion && it["return"] != null) it["return"](); } finally { if (didErr) throw err; } } }; }

function _unsupportedIterableToArray(o, minLen) { var _context2; if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = _sliceInstanceProperty(_context2 = Object.prototype.toString.call(o)).call(_context2, 8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return _Array$from(o); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); }

function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; }

var _marked = /*#__PURE__*/_regeneratorRuntime.mark(makeIterator);

_mapInstanceProperty(Array);

function makeIterator() {
return _regeneratorRuntime.wrap(function makeIterator$(_context) {
while (1) {
switch (_context.prev = _context.next) {
case 0:
_context.next = 2;
return 1;

case 2:
_context.next = 4;
return 2;

case 4:
case "end":
return _context.stop();
}
}
}, _marked);
}

var _iterator = _createForOfIteratorHelper(makeIterator()),
_step;

try {
for (_iterator.s(); !(_step = _iterator.n()).done;) {
var itItem = _step.value;
console.log(itItem);
}
} catch (err) {
_iterator.e(err);
} finally {
_iterator.f();
}