Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @babel/* deps #11899

Merged
merged 2 commits into from Aug 1, 2020
Merged

Update @babel/* deps #11899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66cc36f
chore: remove extra install step for eslint packages
JLHwung Jul 31, 2020
c3af30a
chore: update babel deps
JLHwung Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions Makefile
View file
Open in desktop
Expand Up @@ -252,8 +252,6 @@ endif
bootstrap-only: lerna-bootstrap

yarn-install: clean-all
# Install dependencies in individual packages so that we can link them at the top level.
for package in eslint/*/; do yarn --ignore-engines --cwd $$package; done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we still need this until Babel 8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running yarn install in sub folders incurs changes to the yarn lock files after lerna version, lerna will abort publishing with uncommitted changes. See also the PR descriptions.

# Gitpod prebuilds have a slow network connection, so we need more time
yarn --ignore-engines --network-timeout 100000

Expand Down
2 changes: 0 additions & 2 deletions babel.config.js
View file
Open in desktop
Expand Up @@ -105,8 +105,6 @@ module.exports = function (api) {
// TODO: Use @babel/preset-flow when
// https://github.com/babel/babel/issues/7233 is fixed
"@babel/plugin-transform-flow-strip-types",
["@babel/proposal-class-properties", { loose: true }],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

"@babel/proposal-export-namespace-from",
[
"@babel/proposal-object-rest-spread",
{ useBuiltIns: true, loose: true },
Expand Down
18 changes: 8 additions & 10 deletions package.json
View file
Open in desktop
Expand Up @@ -12,23 +12,21 @@
},
"devDependencies": {
"@babel/cli": "^7.10.4",
"@babel/core": "^7.10.4",
"@babel/core": "^7.11.0",
"@babel/eslint-config-internal": "link:./eslint/babel-eslint-config-internal",
"@babel/eslint-parser": "link:./eslint/babel-eslint-parser",
"@babel/eslint-plugin-development": "link:./eslint/babel-eslint-plugin-development",
"@babel/eslint-parser": "^7.11.0",
"@babel/eslint-plugin-development": "^7.11.0",
"@babel/eslint-plugin-development-internal": "link:./eslint/babel-eslint-plugin-development-internal",
"@babel/plugin-proposal-class-properties": "^7.10.4",
"@babel/plugin-proposal-dynamic-import": "^7.10.4",
"@babel/plugin-proposal-export-namespace-from": "^7.10.4",
"@babel/plugin-proposal-object-rest-spread": "^7.10.4",
"@babel/plugin-proposal-object-rest-spread": "^7.11.0",
"@babel/plugin-transform-flow-strip-types": "^7.10.4",
"@babel/plugin-transform-for-of": "^7.10.4",
"@babel/plugin-transform-modules-commonjs": "^7.10.4",
"@babel/plugin-transform-runtime": "^7.10.4",
"@babel/preset-env": "^7.10.4",
"@babel/plugin-transform-runtime": "^7.11.0",
"@babel/preset-env": "^7.11.0",
"@babel/preset-flow": "^7.10.4",
"@babel/register": "^7.10.4",
"@babel/runtime": "^7.10.4",
"@babel/register": "^7.10.5",
"@babel/runtime": "^7.11.0",
"@rollup/plugin-json": "4.0.1",
"babel-jest": "^24.9.0",
"babel-plugin-transform-charcodes": "^0.2.0",
Expand Down