New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move legacy node version tests to GitHub actions #11952
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27360/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c3cf71c:
|
6a66e97
to
de6e828
Compare
de6e828
to
9f14d98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! not sure where we are documenting supported versions (to build I guess we can put it in contributing, although checking now it looks like we already suggest using > Node 10 there, maybe bump to 12?)
3223832
to
c07cc06
Compare
Awesome! |
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
This PR moves legacy node versions (6.x, 8.x) tests to GitHub versions. The new legacy version test workflow will build Babel on latest node but run unit tests on legacy node. By doing so it paves the way to bump Babel build requirements to
>= 10.13
. Babel 7 still supports node 6, but to build babel project, we requires higher node versions.