Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump semver to 7.0.0 #12015

Merged
merged 3 commits into from Feb 21, 2021
Merged

chore: bump semver to 7.0.0 #12015

merged 3 commits into from Feb 21, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 27, 2020

Q                       A
Any Dependency Changes? semver is bumped to 7.0.0
License MIT

Note that for most users we are already shipping an instance of semver@7.0.0 via core-js-compat. Unfortunately we have to pin semver to 7.0.0 because 7.1.0 will break yarn users on node.js 6.

@babel-bot
Copy link
Collaborator

babel-bot commented Aug 27, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/41642/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e8575f4:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 530550a:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@merceyz
Copy link
Contributor

merceyz commented Aug 28, 2020

Unfortunately we have to pin semver to 7.0.0 because 7.1.0 will break yarn users on node.js 6.

Could use constraints to make sure that is documented and enforced across the repo

@kaicataldo
Copy link
Member

Looks like there are merge conflicts now - should we wait to evaluate this until it's all fixed up?

@JLHwung
Copy link
Contributor Author

JLHwung commented Sep 17, 2020

Could use constraints to make sure that is documented and enforced across the repo

Good idea. I tend to address that in another PR that focused on yarn constraints.

@JLHwung
Copy link
Contributor Author

JLHwung commented Sep 17, 2020

@kaicataldo Resolved conflicts.

// We want to enable it without `loose: true`, since it breaks
// https://github.com/npm/node-semver/blob/093b40f8a7cb67946527b739fe8f8974c888e2a0/classes/range.js#L136
// in our dependencies
"transform-spread",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With assumptions this will be easier 😂

@argshook
Copy link

Howdy, just wanted to inform that using semver pinned to 7.0.0 causes issues when @babel/core is required within webpack.

in our case we have a code editor running in browser, which uses babel parser. After upgrading babel to 7.13.1 we also got semver@7.0.0

looks like semver themselves are aware of this issue npm/node-semver#306 and since then has fixed it.

maybe consider using semver@7.1.2?

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Feb 23, 2021

We can't upgrade because ^7.1.0 contains a breaking change that would be reflected to our users, but I would happily accept a PR to downgrade to ^6 (even if "Babel supports being bundled" is not really a design goal).

@EricMCornelius
Copy link

@nicolo-ribaudo - can you elaborate? What breaking change in semver ^7.1.0 is going to cause the issue?

Bundling babel is very useful from a performance perspective - as observed here: #9575

The reduction in startup time and memory consumption for our CI build as a result are significant - would be a shame to lose the ability.

@merceyz
Copy link
Contributor

merceyz commented Feb 23, 2021

@nicolo-ribaudo - can you elaborate? What breaking change in semver ^7.1.0 is going to cause the issue?

See this thread npm/node-semver@d61f828#r36469180

@EricMCornelius
Copy link

@merceyz - thanks.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants