New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump semver to 7.0.0 #12015
chore: bump semver to 7.0.0 #12015
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/41642/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e8575f4:
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 530550a:
|
Could use constraints to make sure that is documented and enforced across the repo |
Looks like there are merge conflicts now - should we wait to evaluate this until it's all fixed up? |
9fc42e8
to
971c8c4
Compare
Good idea. I tend to address that in another PR that focused on |
@kaicataldo Resolved conflicts. |
971c8c4
to
e93aac8
Compare
e93aac8
to
eb35cf6
Compare
d08b1e9
to
12bfce1
Compare
ada482e
to
20fb329
Compare
a8906e6
to
c0e7fe1
Compare
// We want to enable it without `loose: true`, since it breaks | ||
// https://github.com/npm/node-semver/blob/093b40f8a7cb67946527b739fe8f8974c888e2a0/classes/range.js#L136 | ||
// in our dependencies | ||
"transform-spread", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With assumptions
this will be easier 😂
c0e7fe1
to
530550a
Compare
Howdy, just wanted to inform that using in our case we have a code editor running in browser, which uses babel parser. After upgrading babel to looks like semver themselves are aware of this issue npm/node-semver#306 and since then has fixed it. maybe consider using |
We can't upgrade because |
@nicolo-ribaudo - can you elaborate? What breaking change in semver ^7.1.0 is going to cause the issue? Bundling babel is very useful from a performance perspective - as observed here: #9575 The reduction in startup time and memory consumption for our CI build as a result are significant - would be a shame to lose the ability. |
See this thread npm/node-semver@d61f828#r36469180 |
@merceyz - thanks. |
semver
is bumped to 7.0.0Note that for most users we are already shipping an instance of
semver@7.0.0
via core-js-compat. Unfortunately we have to pinsemver
to 7.0.0 because 7.1.0 will break yarn users on node.js 6.