New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String import/export specifier #12091
Merged
nicolo-ribaudo
merged 25 commits into
babel:main
from
JLHwung:string-module-specifier-name
Oct 14, 2020
Merged
Changes from 21 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
db00d85
feat: parse moduleExportName
JLHwung 356fd9e
feat: add validators
JLHwung 1a6b13f
Support string specifier name in commonjs transform
JLHwung 00276bc
Support string specifier name in export-ns-from
JLHwung b71d726
test: add loose testcases
JLHwung 7f914d3
test: add testcases for amd and umd
JLHwung 463b3e1
feat: support systemjs
JLHwung b6c441c
test: update fixtures fixed in #12110
JLHwung 730eca0
add plugin name typings
JLHwung e2e1d0b
test: rename test layout
JLHwung e14a03a
feat: implement under moduleStringNames flag
JLHwung ae9d87a
chore: add plugin syntax module string names
JLHwung c6d3069
feat: support ModuleExportName as ModuleExportName
JLHwung 41407f4
test: update test fixtures
JLHwung f5759d0
fix flow errors
JLHwung ec66634
docs: update AST spec
JLHwung 4f8fce4
feat: support { "some imports" as "some exports" }
JLHwung 823b67b
feat: support { "some imports" as "some exports" } in systemjs
JLHwung 04fa4bf
test: add test on `import { "foo" }`
JLHwung 0b4dc58
Address review comments
JLHwung 9f9597b
add moduleStringNames to missing plugin helpers
JLHwung 5f8e9b7
Apply suggestions from code review
JLHwung f67fba1
update test fixtures
JLHwung 62e7d55
Update packages/babel-parser/src/parser/error-message.js
JLHwung 107444b
update test fixtures
JLHwung File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When can
local
be a string?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.