New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify warning source about underspecified corejs option in preset-env. #12402
Merged
nicolo-ribaudo
merged 5 commits into
babel:main
from
AndrewSouthpaw:clarify-warning-source
Dec 1, 2020
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -160,7 +160,8 @@ export function normalizeCoreJSOption( | |||||||
if (useBuiltIns && corejs === undefined) { | ||||||||
rawVersion = 2; | ||||||||
console.warn( | ||||||||
"\nWARNING: We noticed you're using the `useBuiltIns` option without declaring a " + | ||||||||
"\n[babel-preset-env]" + | ||||||||
"\nWARNING: We noticed you're using the `useBuiltIns` option without declaring a " + | ||||||||
"core-js version. Currently, we assume version 2.x when no version " + | ||||||||
"is passed. Since this default version will likely change in future " + | ||||||||
"versions of Babel, we recommend explicitly setting the core-js version " + | ||||||||
|
@@ -170,7 +171,9 @@ export function normalizeCoreJSOption( | |||||||
"`dependencies` section. If it doesn't, you need to run one of the " + | ||||||||
"following commands:\n\n" + | ||||||||
" npm install --save core-js@2 npm install --save core-js@3\n" + | ||||||||
" yarn add core-js@2 yarn add core-js@3\n", | ||||||||
" yarn add core-js@2 yarn add core-js@3\n\n" + | ||||||||
"More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins\n" + | ||||||||
"More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs", | ||||||||
); | ||||||||
} else if (typeof corejs === "object" && corejs !== null) { | ||||||||
rawVersion = corejs.version; | ||||||||
|
@@ -183,7 +186,8 @@ export function normalizeCoreJSOption( | |||||||
|
||||||||
if (!useBuiltIns && version) { | ||||||||
console.log( | ||||||||
"\nThe `corejs` option only has an effect when the `useBuiltIns` option is not `false`\n", | ||||||||
"\n[babel-preset-env]" + | ||||||||
"\nThe `corejs` option only has an effect when the `useBuiltIns` option is not `false`\n", | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And also here:
Suggested change
(this is not technically a warning, but since it's probably an error in the user's config it's good to mark it as such). |
||||||||
); | ||||||||
} | ||||||||
|
||||||||
|
1 change: 1 addition & 0 deletions
1
packages/babel-preset-env/test/fixtures/debug/corejs-without-usebuiltins/stdout.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 5 additions & 1 deletion
6
packages/babel-preset-env/test/fixtures/debug/entry-no-corejs-no-import/stderr.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
[babel-preset-env] | ||
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. | ||
|
||
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: | ||
|
||
npm install --save core-js@2 npm install --save core-js@3 | ||
yarn add core-js@2 yarn add core-js@3 | ||
yarn add core-js@2 yarn add core-js@3 | ||
|
||
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins | ||
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs |
6 changes: 5 additions & 1 deletion
6
packages/babel-preset-env/test/fixtures/debug/entry-no-corejs-shippedProposals/stderr.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
[babel-preset-env] | ||
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. | ||
|
||
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: | ||
|
||
npm install --save core-js@2 npm install --save core-js@3 | ||
yarn add core-js@2 yarn add core-js@3 | ||
yarn add core-js@2 yarn add core-js@3 | ||
|
||
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins | ||
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs |
6 changes: 5 additions & 1 deletion
6
packages/babel-preset-env/test/fixtures/debug/entry-no-corejs-uglify/stderr.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
[babel-preset-env] | ||
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. | ||
|
||
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: | ||
|
||
npm install --save core-js@2 npm install --save core-js@3 | ||
yarn add core-js@2 yarn add core-js@3 | ||
yarn add core-js@2 yarn add core-js@3 | ||
|
||
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins | ||
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs |
6 changes: 5 additions & 1 deletion
6
packages/babel-preset-env/test/fixtures/debug/entry-no-corejs/stderr.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
[babel-preset-env] | ||
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. | ||
|
||
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: | ||
|
||
npm install --save core-js@2 npm install --save core-js@3 | ||
yarn add core-js@2 yarn add core-js@3 | ||
yarn add core-js@2 yarn add core-js@3 | ||
|
||
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins | ||
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs |
4 changes: 4 additions & 0 deletions
4
packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-1/stderr.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
[babel-preset-env] | ||
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. | ||
|
||
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: | ||
|
||
npm install --save core-js@2 npm install --save core-js@3 | ||
yarn add core-js@2 yarn add core-js@3 | ||
|
||
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins | ||
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs |
4 changes: 4 additions & 0 deletions
4
packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-2/stderr.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
[babel-preset-env] | ||
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. | ||
|
||
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: | ||
|
||
npm install --save core-js@2 npm install --save core-js@3 | ||
yarn add core-js@2 yarn add core-js@3 | ||
|
||
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins | ||
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs |
6 changes: 5 additions & 1 deletion
6
packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-none-1/stderr.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
[babel-preset-env] | ||
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. | ||
|
||
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: | ||
|
||
npm install --save core-js@2 npm install --save core-js@3 | ||
yarn add core-js@2 yarn add core-js@3 | ||
yarn add core-js@2 yarn add core-js@3 | ||
|
||
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins | ||
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs |
6 changes: 5 additions & 1 deletion
6
packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-none-2/stderr.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
[babel-preset-env] | ||
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. | ||
|
||
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: | ||
|
||
npm install --save core-js@2 npm install --save core-js@3 | ||
yarn add core-js@2 yarn add core-js@3 | ||
yarn add core-js@2 yarn add core-js@3 | ||
|
||
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins | ||
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer something like