Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use browserlists default as the default target of preset-env #12616

Closed
wants to merge 2 commits into from
Closed

Use browserlists default as the default target of preset-env #12616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
240f9e1
breaking: do not override browser defaults in preset-env
JLHwung Jan 12, 2021
990f943
chore: update test fixtures
JLHwung Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 15 additions & 11 deletions packages/babel-helper-compilation-targets/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,15 +180,17 @@ export default function getTargets(
!options.ignoreBrowserslistConfig && !hasTargets;

if (shouldParseBrowsers || shouldSearchForConfig) {
// If no targets are passed, we need to overwrite browserslist's defaults
// so that we enable all transforms (acting like the now deprecated
// preset-latest).
//
// Note, if browserslist resolves the config (ex. package.json), then usage
// of `defaults` in queries will be different since we don't want to break
// the behavior of "no targets is the same as preset-latest".
if (!hasTargets) {
browserslist.defaults = [];
if (!process.env.BABEL_8_BREAKING) {
// If no targets are passed, we need to overwrite browserslist's defaults
// so that we enable all transforms (acting like the now deprecated
// preset-latest).
//
// Note, if browserslist resolves the config (ex. package.json), then usage
// of `defaults` in queries will be different since we don't want to break
// the behavior of "no targets is the same as preset-latest".
if (!hasTargets) {
browserslist.defaults = [];
}
}

const browsers = browserslist(browsersquery, {
Expand All @@ -200,8 +202,10 @@ export default function getTargets(
const queryBrowsers = getLowestVersions(browsers);
targets = Object.assign(queryBrowsers, targets);

// Reset browserslist defaults
browserslist.defaults = browserslistDefaults;
if (!process.env.BABEL_8_BREAKING) {
// Reset browserslist defaults
browserslist.defaults = browserslistDefaults;
}
}

// Parse remaining targets
Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/corejs2/entry-all-babel-7/input.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import "@babel/polyfill";
13 changes: 13 additions & 0 deletions packages/babel-preset-env/test/fixtures/corejs2/entry-all-babel-7/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"presets": [
[
"../../../../lib",
{
"modules": false,
"useBuiltIns": "entry",
"corejs": 2
}
]
],
"BABEL_8_BREAKING": false
}
149 changes: 149 additions & 0 deletions packages/babel-preset-env/test/fixtures/corejs2/entry-all-babel-7/output.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,149 @@
import "core-js/modules/es6.array.copy-within.js";
import "core-js/modules/es6.array.every.js";
import "core-js/modules/es6.array.fill.js";
import "core-js/modules/es6.array.filter.js";
import "core-js/modules/es6.array.find.js";
import "core-js/modules/es6.array.find-index.js";
import "core-js/modules/es7.array.flat-map.js";
import "core-js/modules/es6.array.for-each.js";
import "core-js/modules/es6.array.from.js";
import "core-js/modules/es7.array.includes.js";
import "core-js/modules/es6.array.index-of.js";
import "core-js/modules/es6.array.is-array.js";
import "core-js/modules/es6.array.iterator.js";
import "core-js/modules/es6.array.last-index-of.js";
import "core-js/modules/es6.array.map.js";
import "core-js/modules/es6.array.of.js";
import "core-js/modules/es6.array.reduce.js";
import "core-js/modules/es6.array.reduce-right.js";
import "core-js/modules/es6.array.some.js";
import "core-js/modules/es6.array.sort.js";
import "core-js/modules/es6.array.species.js";
import "core-js/modules/es6.date.now.js";
import "core-js/modules/es6.date.to-iso-string.js";
import "core-js/modules/es6.date.to-json.js";
import "core-js/modules/es6.date.to-primitive.js";
import "core-js/modules/es6.date.to-string.js";
import "core-js/modules/es6.function.bind.js";
import "core-js/modules/es6.function.has-instance.js";
import "core-js/modules/es6.function.name.js";
import "core-js/modules/es6.map.js";
import "core-js/modules/es6.math.acosh.js";
import "core-js/modules/es6.math.asinh.js";
import "core-js/modules/es6.math.atanh.js";
import "core-js/modules/es6.math.cbrt.js";
import "core-js/modules/es6.math.clz32.js";
import "core-js/modules/es6.math.cosh.js";
import "core-js/modules/es6.math.expm1.js";
import "core-js/modules/es6.math.fround.js";
import "core-js/modules/es6.math.hypot.js";
import "core-js/modules/es6.math.imul.js";
import "core-js/modules/es6.math.log1p.js";
import "core-js/modules/es6.math.log10.js";
import "core-js/modules/es6.math.log2.js";
import "core-js/modules/es6.math.sign.js";
import "core-js/modules/es6.math.sinh.js";
import "core-js/modules/es6.math.tanh.js";
import "core-js/modules/es6.math.trunc.js";
import "core-js/modules/es6.number.constructor.js";
import "core-js/modules/es6.number.epsilon.js";
import "core-js/modules/es6.number.is-finite.js";
import "core-js/modules/es6.number.is-integer.js";
import "core-js/modules/es6.number.is-nan.js";
import "core-js/modules/es6.number.is-safe-integer.js";
import "core-js/modules/es6.number.max-safe-integer.js";
import "core-js/modules/es6.number.min-safe-integer.js";
import "core-js/modules/es6.number.parse-float.js";
import "core-js/modules/es6.number.parse-int.js";
import "core-js/modules/es6.object.assign.js";
import "core-js/modules/es6.object.create.js";
import "core-js/modules/es7.object.define-getter.js";
import "core-js/modules/es7.object.define-setter.js";
import "core-js/modules/es6.object.define-property.js";
import "core-js/modules/es6.object.define-properties.js";
import "core-js/modules/es7.object.entries.js";
import "core-js/modules/es6.object.freeze.js";
import "core-js/modules/es6.object.get-own-property-descriptor.js";
import "core-js/modules/es7.object.get-own-property-descriptors.js";
import "core-js/modules/es6.object.get-own-property-names.js";
import "core-js/modules/es6.object.get-prototype-of.js";
import "core-js/modules/es7.object.lookup-getter.js";
import "core-js/modules/es7.object.lookup-setter.js";
import "core-js/modules/es6.object.prevent-extensions.js";
import "core-js/modules/es6.object.to-string.js";
import "core-js/modules/es6.object.is.js";
import "core-js/modules/es6.object.is-frozen.js";
import "core-js/modules/es6.object.is-sealed.js";
import "core-js/modules/es6.object.is-extensible.js";
import "core-js/modules/es6.object.keys.js";
import "core-js/modules/es6.object.seal.js";
import "core-js/modules/es6.object.set-prototype-of.js";
import "core-js/modules/es7.object.values.js";
import "core-js/modules/es6.promise.js";
import "core-js/modules/es7.promise.finally.js";
import "core-js/modules/es6.reflect.apply.js";
import "core-js/modules/es6.reflect.construct.js";
import "core-js/modules/es6.reflect.define-property.js";
import "core-js/modules/es6.reflect.delete-property.js";
import "core-js/modules/es6.reflect.get.js";
import "core-js/modules/es6.reflect.get-own-property-descriptor.js";
import "core-js/modules/es6.reflect.get-prototype-of.js";
import "core-js/modules/es6.reflect.has.js";
import "core-js/modules/es6.reflect.is-extensible.js";
import "core-js/modules/es6.reflect.own-keys.js";
import "core-js/modules/es6.reflect.prevent-extensions.js";
import "core-js/modules/es6.reflect.set.js";
import "core-js/modules/es6.reflect.set-prototype-of.js";
import "core-js/modules/es6.regexp.constructor.js";
import "core-js/modules/es6.regexp.flags.js";
import "core-js/modules/es6.regexp.match.js";
import "core-js/modules/es6.regexp.replace.js";
import "core-js/modules/es6.regexp.split.js";
import "core-js/modules/es6.regexp.search.js";
import "core-js/modules/es6.regexp.to-string.js";
import "core-js/modules/es6.set.js";
import "core-js/modules/es6.symbol.js";
import "core-js/modules/es7.symbol.async-iterator.js";
import "core-js/modules/es6.string.anchor.js";
import "core-js/modules/es6.string.big.js";
import "core-js/modules/es6.string.blink.js";
import "core-js/modules/es6.string.bold.js";
import "core-js/modules/es6.string.code-point-at.js";
import "core-js/modules/es6.string.ends-with.js";
import "core-js/modules/es6.string.fixed.js";
import "core-js/modules/es6.string.fontcolor.js";
import "core-js/modules/es6.string.fontsize.js";
import "core-js/modules/es6.string.from-code-point.js";
import "core-js/modules/es6.string.includes.js";
import "core-js/modules/es6.string.italics.js";
import "core-js/modules/es6.string.iterator.js";
import "core-js/modules/es6.string.link.js";
import "core-js/modules/es7.string.pad-start.js";
import "core-js/modules/es7.string.pad-end.js";
import "core-js/modules/es6.string.raw.js";
import "core-js/modules/es6.string.repeat.js";
import "core-js/modules/es6.string.small.js";
import "core-js/modules/es6.string.starts-with.js";
import "core-js/modules/es6.string.strike.js";
import "core-js/modules/es6.string.sub.js";
import "core-js/modules/es6.string.sup.js";
import "core-js/modules/es6.string.trim.js";
import "core-js/modules/es7.string.trim-left.js";
import "core-js/modules/es7.string.trim-right.js";
import "core-js/modules/es6.typed.array-buffer.js";
import "core-js/modules/es6.typed.data-view.js";
import "core-js/modules/es6.typed.int8-array.js";
import "core-js/modules/es6.typed.uint8-array.js";
import "core-js/modules/es6.typed.uint8-clamped-array.js";
import "core-js/modules/es6.typed.int16-array.js";
import "core-js/modules/es6.typed.uint16-array.js";
import "core-js/modules/es6.typed.int32-array.js";
import "core-js/modules/es6.typed.uint32-array.js";
import "core-js/modules/es6.typed.float32-array.js";
import "core-js/modules/es6.typed.float64-array.js";
import "core-js/modules/es6.weak-map.js";
import "core-js/modules/es6.weak-set.js";
import "core-js/modules/web.timers.js";
import "core-js/modules/web.immediate.js";
import "core-js/modules/web.dom.iterable.js";
import "regenerator-runtime/runtime.js";
3 changes: 2 additions & 1 deletion packages/babel-preset-env/test/fixtures/corejs2/entry-all/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@
"corejs": 2
}
]
]
],
"BABEL_8_BREAKING": true
}
22 changes: 0 additions & 22 deletions packages/babel-preset-env/test/fixtures/corejs2/entry-all/output.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,14 @@
import "core-js/modules/es6.array.copy-within.js";
import "core-js/modules/es6.array.every.js";
import "core-js/modules/es6.array.fill.js";
import "core-js/modules/es6.array.filter.js";
import "core-js/modules/es6.array.find.js";
import "core-js/modules/es6.array.find-index.js";
import "core-js/modules/es7.array.flat-map.js";
import "core-js/modules/es6.array.for-each.js";
import "core-js/modules/es6.array.from.js";
import "core-js/modules/es7.array.includes.js";
import "core-js/modules/es6.array.index-of.js";
import "core-js/modules/es6.array.is-array.js";
import "core-js/modules/es6.array.iterator.js";
import "core-js/modules/es6.array.last-index-of.js";
import "core-js/modules/es6.array.map.js";
import "core-js/modules/es6.array.of.js";
import "core-js/modules/es6.array.reduce.js";
import "core-js/modules/es6.array.reduce-right.js";
import "core-js/modules/es6.array.some.js";
import "core-js/modules/es6.array.sort.js";
import "core-js/modules/es6.array.species.js";
import "core-js/modules/es6.date.now.js";
import "core-js/modules/es6.date.to-iso-string.js";
import "core-js/modules/es6.date.to-json.js";
import "core-js/modules/es6.date.to-primitive.js";
import "core-js/modules/es6.date.to-string.js";
import "core-js/modules/es6.function.bind.js";
import "core-js/modules/es6.function.has-instance.js";
import "core-js/modules/es6.function.name.js";
import "core-js/modules/es6.map.js";
Expand Down Expand Up @@ -56,11 +40,8 @@ import "core-js/modules/es6.number.min-safe-integer.js";
import "core-js/modules/es6.number.parse-float.js";
import "core-js/modules/es6.number.parse-int.js";
import "core-js/modules/es6.object.assign.js";
import "core-js/modules/es6.object.create.js";
import "core-js/modules/es7.object.define-getter.js";
import "core-js/modules/es7.object.define-setter.js";
import "core-js/modules/es6.object.define-property.js";
import "core-js/modules/es6.object.define-properties.js";
import "core-js/modules/es7.object.entries.js";
import "core-js/modules/es6.object.freeze.js";
import "core-js/modules/es6.object.get-own-property-descriptor.js";
Expand All @@ -77,7 +58,6 @@ import "core-js/modules/es6.object.is-sealed.js";
import "core-js/modules/es6.object.is-extensible.js";
import "core-js/modules/es6.object.keys.js";
import "core-js/modules/es6.object.seal.js";
import "core-js/modules/es6.object.set-prototype-of.js";
import "core-js/modules/es7.object.values.js";
import "core-js/modules/es6.promise.js";
import "core-js/modules/es7.promise.finally.js";
Expand Down Expand Up @@ -127,11 +107,9 @@ import "core-js/modules/es6.string.starts-with.js";
import "core-js/modules/es6.string.strike.js";
import "core-js/modules/es6.string.sub.js";
import "core-js/modules/es6.string.sup.js";
import "core-js/modules/es6.string.trim.js";
import "core-js/modules/es7.string.trim-left.js";
import "core-js/modules/es7.string.trim-right.js";
import "core-js/modules/es6.typed.array-buffer.js";
import "core-js/modules/es6.typed.data-view.js";
import "core-js/modules/es6.typed.int8-array.js";
import "core-js/modules/es6.typed.uint8-array.js";
import "core-js/modules/es6.typed.uint8-clamped-array.js";
Expand Down
8 changes: 8 additions & 0 deletions packages/babel-preset-env/test/fixtures/corejs2/entry-shippedProposals-babel-7/input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
require("@babel/polyfill");

let { x, y, ...z } = { x: 1, y: 2, a: 3, b: 4 };
let n = { x, y, ...z };
async function* agf() {
await 1;
yield 2;
}
14 changes: 14 additions & 0 deletions packages/babel-preset-env/test/fixtures/corejs2/entry-shippedProposals-babel-7/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"presets": [
[
"../../../../lib",
{
"shippedProposals": true,
"useBuiltIns": "entry",
"corejs": 2
}
]
],
"plugins": [["external-helpers", { "helperVersion": "7.100.0" }]],
"BABEL_8_BREAKING": false
}