Evaluate object and initializer when setting a private method #12707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
JLHwung
commented
Jan 28, 2021
packages/babel-helper-create-class-features-plugin/src/fields.js
Outdated
Show resolved
Hide resolved
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/43268/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8388185:
|
...es/babel-plugin-proposal-private-methods/test/fixtures/private-method/reassignment/output.js
Outdated
Show resolved
Hide resolved
jridgewell
approved these changes
Jan 28, 2021
...el-plugin-proposal-private-methods/test/fixtures/private-method-loose/reassignment/output.js
Show resolved
Hide resolved
jridgewell
reviewed
Jan 28, 2021
|
@JLHwung Could you rebase this? 🙏 |
| @@ -14,7 +14,7 @@ class Cl { | |||
| value: 0 | |||
| }); | |||
|
|
|||
| babelHelpers.readOnlyError("#privateFieldValue"); | |||
| this, 1, babelHelpers.readOnlyError("#privateFieldValue"); | |||
There was a problem hiding this comment.
This is a few more unnecessary bytes, but this path will always result in an error so it's highly improbable that it will happen in production code.
nicolo-ribaudo
approved these changes
Mar 1, 2021
nicolo-ribaudo
changed the title
nicolo-ribaudo
approved these changes
Mar 1, 2021
|
I rewrote the title to keep it short enough while still adding info about the last two commits. |
This was referenced Mar 8, 2021
This was referenced Mar 17, 2021
Closed
Closed
Merged
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass down
valueto the argument ofclassPrivateMethodSetso it will always be evaluated before a runtime error is thrown.