Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate object and initializer when setting a private method #12707

Merged
merged 5 commits into from Mar 1, 2021
Merged

Evaluate object and initializer when setting a private method #12707

merged 5 commits into from Mar 1, 2021

Commits on Mar 1, 2021

  1. fix: evaluate initializer when a private method is set as a field

    @JLHwung
    JLHwung committed Mar 1, 2021
    Copy the full SHA
    2a1999e View commit details
    Browse the repository at this point in the history

  2. make legacy node happy

    @JLHwung
    JLHwung committed Mar 1, 2021
    Copy the full SHA
    f58c7a5 View commit details
    Browse the repository at this point in the history

  3. add accessor test cases

    @JLHwung
    JLHwung committed Mar 1, 2021
    Copy the full SHA
    430c7f8 View commit details
    Browse the repository at this point in the history

  4. fix: evaluate object before RHS

    @JLHwung
    JLHwung committed Mar 1, 2021
    Copy the full SHA
    2e545f2 View commit details
    Browse the repository at this point in the history

  5. fix: evaluate object before throwing writeOnlyError

    @JLHwung
    JLHwung committed Mar 1, 2021
    Copy the full SHA
    8388185 View commit details
    Browse the repository at this point in the history