Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[babel-cli] Don't fail when chmod throws an error #12846

Merged
merged 4 commits into from Feb 22, 2021

Conversation

immitsu
Copy link
Contributor

@immitsu immitsu commented Feb 22, 2021

Q                       A
Fixed Issues? Fixes #12835
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added pkg: cli PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Feb 22, 2021
@nicolo-ribaudo nicolo-ribaudo changed the title [12835] Added try/catch to babel-cli chmod [babel-cli] Don't fail when chmod throws an error Feb 22, 2021
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 22, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 68e573a:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 22, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/41750/

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
@fedeci
Copy link
Member

fedeci commented Feb 22, 2021

To test it:

it("should warn the user if chmod fails", () => {
  const spyConsoleWarn = jest.spyOn(console, "warn");
  // should expect a string as first argument
  chmod(100, "file.js");
  expect(spyConsoleWarn).toHaveBeenCalledTimes(1);
  spyConsoleWarn.mockRestore();
});

@immitsu
Copy link
Contributor Author

immitsu commented Feb 22, 2021

@fedeci Added it, thanks!

Co-authored-by: Federico Ciardi <fed.ciardi@gmail.com>
This was referenced Mar 14, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: cli PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

babel-cli chmod doesn't always work
5 participants