New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[babel-cli] Don't fail when chmod
throws an error
#12846
Conversation
immitsu
commented
Feb 22, 2021
•
edited
edited
Q | A |
---|---|
Fixed Issues? | Fixes #12835 |
Patch: Bug Fix? | |
Major: Breaking Change? | |
Minor: New Feature? | |
Tests Added + Pass? | Yes |
Documentation PR Link | |
Any Dependency Changes? | |
License | MIT |
chmod
throws an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 68e573a:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/41750/ |
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
To test it: it("should warn the user if chmod fails", () => {
const spyConsoleWarn = jest.spyOn(console, "warn");
// should expect a string as first argument
chmod(100, "file.js");
expect(spyConsoleWarn).toHaveBeenCalledTimes(1);
spyConsoleWarn.mockRestore();
}); |
@fedeci Added it, thanks! |
Co-authored-by: Federico Ciardi <fed.ciardi@gmail.com>