Enable external-helpers by default in tests
#12911
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 59dc102:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/42922/ |
There was a problem hiding this comment.
💯💯 amazing idea, makes a lot of sense! I'm just wondering where we want to document this like in contributing that this is the default or in some readme's in the test runner?
like a section in https://github.com/babel/babel/blob/main/CONTRIBUTING.md#babelplugin-x? We don't have that many docs on helpers in general really or explaining that we need them
nicolo-ribaudo
force-pushed
the
test-external-helpers
branch
from
6dd7c5d
to
1c83409
Compare
|
Good idea, I added a small section to |
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
babel#12911 was a breaking change that now requires you to keep `babel-plugin-external-helpers` in your `package.json`. It'll will probably be unnoticeable for most, because another dependency could transitively depend on it, but AMP recently hit it when cleaning up our deps.
* Optionally enable external-helpers in tests #12911 was a breaking change that now requires you to keep `babel-plugin-external-helpers` in your `package.json`. It'll will probably be unnoticeable for most, because another dependency could transitively depend on it, but AMP recently hit it when cleaning up our deps. * Cast to boolean * Fix package name
github-actions
bot
added
the
outdated
This PR updates our test runner so that it always uses the
external-helpersplugin, unless it's disabled with"externalHelpers": falseinoptions.json.This has the following advantages:
output.jsfiles, helping reviewers focusing on the important outputhelperVersionoption, rather than hundreds of them.This PR is inspired from #11285 (comment).
but I can't find it anymore😅