Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure static private method init run before static property #12918

Merged
merged 3 commits into from Mar 3, 2021
Merged

Ensure static private method init run before static property #12918

merged 3 commits into from Mar 3, 2021

Commits on Mar 3, 2021

  1. fix: ensure static private method init run before static property init 

    Per 15.7.12 Runtime Semantics: ClassDefinitionEvaluation, when DefineField is invoked, the class binding used in field initializer will have a receiver F, which has all static methods defined but may still have uninvoked initializer due to the order of DefineField executions on staticFields. Therefore, we place static class methods definition before static field.
    @JLHwung
    JLHwung committed Mar 3, 2021
    Copy the full SHA
    ea1f619 View commit details
    Browse the repository at this point in the history

  2. revise test cases on the correct behavior

    @JLHwung
    JLHwung committed Mar 3, 2021
    Copy the full SHA
    6daf911 View commit details
    Browse the repository at this point in the history

  3. chore: update test fixtures

    @JLHwung
    JLHwung committed Mar 3, 2021
    Copy the full SHA
    4ca3404 View commit details
    Browse the repository at this point in the history