Add support for the "Hack" pipeline proposal #13191

js-choi · 2021-04-22T02:15:36Z

Q	A
Fixed Issues?	None
Patch: Bug Fix?	No
Major: Breaking Change?	No
Minor: New Feature?	Yes
Tests Added + Pass?	Yes
Documentation PR Link	babel/website#2541
Any Dependency Changes?	No
License	MIT

@xixixao and I discussed it a bit more over email, and since he’s dealing with another open-source project, he won’t be able to work on #11600 much for the foreseeable future. So I’ll just open a pull request of my own for the Hack-pipes proposal under consideration by TC39. CC @tabatkins, @ljharb, @mAAdhaTTah.

In preparation for upcoming renaming commit. Titles are now already arguably more readable.

See babel#11600 and https://github.com/js-choi/proposal-hack-pipes.

Unwrap and remove the PipelineBody, PipelineBareFunctionBody, PipelineBareConstructorBody, PipelineBareAwaitedFunctionBody, PipelineTopicBody, and PipelineStyle types.

The “primary” part was a vestige of the old smart-mix pipeline proposal.

As per babel#13130 and babel#11600 (comment).

For backwards compatibility until next major change. To maintain simplicity in the code before smart mix is removed, smart mix was modified to match the new Hack-pipe proposal: • No early errors for sequences in pipe heads or bodies. • Function declarations and if/catch/for/with statements do not hide outer topics.

In anticipation of test fixtures for other topic tokens.

Failure was due to lack of support for async functions.

codesandbox-ci · 2021-04-22T02:19:58Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 640d974:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

mAAdhaTTah · 2021-04-22T15:16:23Z

Rename "smart" pipe-proposal option to "hack"

This is going to break backwards compatibility so I don't think we can do this.

JLHwung · 2021-04-22T15:40:18Z

Rename "smart" pipe-proposal option to "hack"

This is going to break backwards compatibility so I don't think we can do this.

It has been reverted in 11a7a49.

JLHwung · 2021-04-22T15:44:38Z

@js-choi You can skip the async function execution tests on Node.js 6 like we did in https://github.com/babel/babel/blob/672a58660f0b15691c44582f1f3fdcdac0fa0d2f/packages/babel-plugin-proposal-do-expressions/test/fixtures/do-expressions/yield/options.json

packages/babel-parser/src/parser/expression.js

packages/babel-parser/src/parser/error-message.js

packages/babel-parser/src/parser/statement.js

packages/babel-parser/src/parser/expression.js

packages/babel-plugin-proposal-pipeline-operator/src/hackVisitor.js

js-choi · 2021-05-30T11:53:15Z

I noted some further missing smart-mix test fixtures, which I added back. I manually reviewed everything, and as far as I can tell, there should be nothing else missing. I also changed the unbound-topic error and comma-head error to match the old behavior of the smart-mix mode. Every issue raised so far should be now fully addressed, as far as I can tell.

I’m not sure why the create-react-app CI check is failing; I am unable to reproduce it.

js-choi · 2021-05-30T14:17:22Z

Need to add a check for the conflict between pipelineOperator: { topicToken: "#" } and recordAndtuple: { syntaxType: "hash"} due to #[]. See tc39/proposal-hack-pipes#2 (comment).

Edit: This is done in 7cdf3ac and 640d974.

nicolo-ribaudo · 2021-05-31T17:16:14Z

I’m not sure why the create-react-app CI check is failing; I am unable to reproduce it.

e2e tests are sometimes flaky; that specific failure seems completely unrelated to this PR.

nicolo-ribaudo

I left one last comment, but otherwise this PR looks good 👍

packages/babel-parser/src/parser/expression.js

nicolo-ribaudo · 2021-06-02T15:05:25Z

Do you want me to squash-merge this into a feat-7.15.0/hack-pipes branch so that you can open a PR for % on top of that?

js-choi · 2021-06-02T15:13:35Z

@nicolo-ribaudo That plan sounds good. 👍

nicolo-ribaudo · 2021-06-02T21:54:27Z

Merged in https://github.com/babel/babel/tree/feat-7.15.0/hack-pipes! I you'll need that branch to be rebased let me know.

Fix errors for invalid topic references so that the errors point to the topic tokens themselves, rather than immediately after them. Reverts a breaking change to smart-mix pipe error positions made in babel#13191.

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

js-choi added 17 commits April 14, 2021 10:42

Add comment about Hack-style pipeline arrow-function early error

5701fd4

Remove obsoleted smart-mix pipe early errors about sequence expressions

740cec3

Remove obsoleted smart-mix pipe early errors about statements

9277286

Remove obsoleted smart-mix pipe's bare-style's parser tests

b18f23e

Remove obsoleted smart-mix pipe's bare style from parser

4019b6d

Rename pipe-operator parser fixture titles

173f2ff

In preparation for upcoming renaming commit. Titles are now already arguably more readable.

Rename "smart" pipe-proposal option to "hack"

d83b79d

See babel#11600 and https://github.com/js-choi/proposal-hack-pipes.

Simplify Hack-style pipe AST

8fb52c4

Unwrap and remove the PipelineBody, PipelineBareFunctionBody, PipelineBareConstructorBody, PipelineBareAwaitedFunctionBody, PipelineTopicBody, and PipelineStyle types.

babel-generator: Add tests for topic reference

d436a83

Rename “primary topic reference” to “topic reference”

b5be14e

The “primary” part was a vestige of the old smart-mix pipeline proposal.

Change new error messages to match consistent Babel style

69fbd55

As per babel#13130 and babel#11600 (comment).

More tests for Hack-style pipes in anticipation of other topic tokens

e788c5e

Hack pipes now require that a topic token be specified

f58fcf6

Rename Hack-pipe test fixtures

5ae15aa

In anticipation of test fixtures for other topic tokens.

Fix failing pipe tests on Node 6

8de5e4f

Failure was due to lack of support for async functions.

Add warning about deprecation of smart-mix pipe

e325241

ljharb added the Spec: Pipeline Operator label Apr 22, 2021

nicolo-ribaudo self-requested a review April 22, 2021 07:55

nicolo-ribaudo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Apr 22, 2021

js-choi changed the title ~~Proposal hack pipes~~ Proposal: Hack pipes Apr 22, 2021

JLHwung self-requested a review April 22, 2021 15:35

xixixao mentioned this pull request Apr 24, 2021

Add hack style pipeline proposal #11600

Closed

nicolo-ribaudo added this to the v7.15.0 milestone May 1, 2021

nicolo-ribaudo reviewed May 1, 2021

View reviewed changes

packages/babel-parser/src/parser/expression.js Outdated Show resolved Hide resolved

packages/babel-parser/src/parser/expression.js Outdated Show resolved Hide resolved

packages/babel-parser/src/parser/error-message.js Outdated Show resolved Hide resolved

JLHwung reviewed May 10, 2021

View reviewed changes

packages/babel-parser/src/parser/statement.js Show resolved Hide resolved

packages/babel-parser/src/parser/expression.js Show resolved Hide resolved

packages/babel-plugin-proposal-pipeline-operator/src/hackVisitor.js Outdated Show resolved Hide resolved

parser: Check conflict between hash topic tokens and tuples

7cdf3ac

nicolo-ribaudo reviewed Jun 2, 2021

View reviewed changes

packages/babel-parser/src/parser/expression.js Show resolved Hide resolved

nicolo-ribaudo approved these changes Jun 2, 2021

View reviewed changes

parser/plugin-pipeline: Minor hash-tuple test changes

640d974

nicolo-ribaudo changed the base branch from main to feat-7.15.0/hack-pipes June 2, 2021 21:53

nicolo-ribaudo changed the title ~~Proposal: Hack pipes~~ Add support for the "Hack" pipeline proposal Jun 2, 2021

nicolo-ribaudo merged commit b5adde3 into babel:feat-7.15.0/hack-pipes Jun 2, 2021

Pipeline Operator automation moved this from In progress to Done Jun 2, 2021

nicolo-ribaudo mentioned this pull request Jun 2, 2021

Add support for the "Hack" pipeline proposal (#13191) #13413

Merged

4 tasks

js-choi mentioned this pull request Jun 3, 2021

Hack-pipe proposal with % topic token #13416

Merged

js-choi mentioned this pull request Jun 5, 2021

parser: Fix Hack/smart-pipe error positions #13426

Merged

js-choi deleted the proposal-hack-pipes branch June 7, 2021 16:00

nicolo-ribaudo added a commit that referenced this pull request Jun 8, 2021

Add support for the "Hack" pipeline proposal (#13191)

a4180e6

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

js-choi mentioned this pull request Jun 19, 2021

Disable smart pipes in v8.0 #13488

Closed

nicolo-ribaudo added a commit that referenced this pull request Jul 6, 2021

Add support for the "Hack" pipeline proposal (#13191)

e926498

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

nicolo-ribaudo added a commit that referenced this pull request Jul 6, 2021

Add support for the "Hack" pipeline proposal (#13191)

ae2533a

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

nicolo-ribaudo added a commit that referenced this pull request Aug 3, 2021

Add support for the "Hack" pipeline proposal (#13191)

c63b17f

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

nicolo-ribaudo added a commit that referenced this pull request Aug 3, 2021

Add support for the "Hack" pipeline proposal (#13191)

6276853

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

This was referenced Aug 5, 2021

chore(deps-dev): bump @babel/eslint-parser from 7.13.14 to 7.15.0 filecoin-project/slate#863

Merged

chore(deps-dev): bump @babel/core from 7.13.14 to 7.15.0 filecoin-project/slate#862

Closed

eventualbuddha mentioned this pull request Aug 19, 2021

Fresh install of decaffeinate is throwing a babel compile error decaffeinate/decaffeinate#2407

Closed

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 7, 2021

github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for the "Hack" pipeline proposal #13191

Add support for the "Hack" pipeline proposal #13191

js-choi commented Apr 22, 2021 •

edited

codesandbox-ci bot commented Apr 22, 2021 •

edited

mAAdhaTTah commented Apr 22, 2021

JLHwung commented Apr 22, 2021

JLHwung commented Apr 22, 2021

js-choi commented May 30, 2021 •

edited

js-choi commented May 30, 2021 •

edited

nicolo-ribaudo commented May 31, 2021

nicolo-ribaudo left a comment

nicolo-ribaudo commented Jun 2, 2021

js-choi commented Jun 2, 2021 •

edited

nicolo-ribaudo commented Jun 2, 2021

Add support for the "Hack" pipeline proposal #13191

Add support for the "Hack" pipeline proposal #13191

Conversation

js-choi commented Apr 22, 2021 • edited

codesandbox-ci bot commented Apr 22, 2021 • edited

mAAdhaTTah commented Apr 22, 2021

JLHwung commented Apr 22, 2021

JLHwung commented Apr 22, 2021

js-choi commented May 30, 2021 • edited

js-choi commented May 30, 2021 • edited

nicolo-ribaudo commented May 31, 2021

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

nicolo-ribaudo commented Jun 2, 2021

js-choi commented Jun 2, 2021 • edited

nicolo-ribaudo commented Jun 2, 2021

js-choi commented Apr 22, 2021 •

edited

codesandbox-ci bot commented Apr 22, 2021 •

edited

js-choi commented May 30, 2021 •

edited

js-choi commented May 30, 2021 •

edited

js-choi commented Jun 2, 2021 •

edited