[babel 8] Add "exports" to every package
#14013
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50326/ |
nicolo-ribaudo
force-pushed
the
babel-8-exports
branch
4 times, most recently
from
0b107fc
to
3c8586b
Compare
nicolo-ribaudo
force-pushed
the
babel-8-exports
branch
from
3c8586b
to
e3ccc40
Compare
TODO: This should be removed in the future.
nicolo-ribaudo
force-pushed
the
babel-8-exports
branch
from
e3ccc40
to
d22fab8
Compare
| }, | ||
| "exports": { | ||
| ".": "./lib/index.js", | ||
| "./package.json": "./package.json" |
There was a problem hiding this comment.
Q: Why should we move the exports to conditions if-else? I perceive that it is to use Babel 7 export-less package.json but don't know what is breaking. I expect every package will eventually come with top level exports, right?
There was a problem hiding this comment.
Actually, I removed this because the file already contains a complex "exports" that lets it work in Babel 7 while also having an ESM entry point. The exports in BABEL_8_BREAKING are a simpler version of what this package already has (you can see it by expanding the diff).
This exports I deleted here was auto-generated by yarn constraints --fix while we didn't have the other exports yet, then I rebased and had to delete it to remove the "conflict".
We would have to expose:
I think it's easier to leave it as-is. |
github-actions
bot
added
the
outdated
nicolo-ribaudo
added
PR: Breaking Change 💥
In Babel 8 we will want to use
"exports"in every package, to prevent people from relying on our internal files. This PR uses a new feature of http://github.com/nicolo-ribaudo/yarn-plugin-conditions/ to specify"exports"when publishing with theBABEL_8_BREAKINGflag (and for our internal development), but to remove it when publishing Babel 7 releases.I also unified the different
"exports"we already had for some Babel 7 packages, by making them expose both".": "./lib/index.js"and"./package.json"(some already did, some didn't) since it's useful when usingrequire.resolveto get the package root, or to get metadata such as the plugin version.The commits prefixed with
RUNare not created manually, but by runningyarn constraints --fixwith the constraints introduced by the previous commit.