Bring back deferred require() calls in core and cli
#14028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
changed the title
requrie() calls in core and clirequire() calls in core and cli
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50180/ |
JLHwung
approved these changes
Dec 5, 2021
nicolo-ribaudo
force-pushed
the
lazy-requires
branch
from
8c34349
to
7031fb3
Compare
|
I just squashed to rebase #14013 on top of this one. |
|
The remaining CRA failure is not related. |
existentialism
approved these changes
Dec 6, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2e-breakingfailure onmain#13966 accidentally introduced a performance regression by removing lazy requires from
@babel/coreand@babel/cli, because the first@babel/transform-modules-commonjsconfiguration was overwritten by the second one.Rather than just reordering them I added an explicit
exclude, so that it's more robust.