New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix update expression for exported bigints #14341
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8a8c1a2
Fix update expression for bigints
magic-akari 2d49032
add `includeUpdateExpression` to avoid breaking change
magic-akari fec2ff5
chore: add comment
magic-akari f63fc73
chore: revert redundant change
magic-akari d8735df
Add test case for simplifyAccess
magic-akari b530c7a
chore: add comment
magic-akari File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,181 @@ | ||
import * as babel from "@babel/core"; | ||
import simplifyAccess from "../lib/index.js"; | ||
|
||
const plugin = (_api, options) => { | ||
const { includeUpdateExpression, bindingNames } = options; | ||
|
||
return { | ||
visitor: { | ||
Program(path) { | ||
simplifyAccess.default( | ||
path, | ||
new Set(bindingNames), | ||
includeUpdateExpression, | ||
); | ||
}, | ||
}, | ||
}; | ||
}; | ||
|
||
it("simplifyAccess with default config", function () { | ||
const code = ` | ||
let a = foo++; | ||
a = ++foo; | ||
foo++; | ||
++foo; | ||
++a; | ||
a++; | ||
foo = a++; | ||
foo = ++a; | ||
|
||
let b = bar--; | ||
b = --bar; | ||
bar--; | ||
--bar; | ||
--b; | ||
b--; | ||
bar = b--; | ||
bar = --b; | ||
|
||
let c = baz += 1; | ||
baz += 1; | ||
c += 1; | ||
|
||
function f() { | ||
let foo = 1; | ||
let a = foo++; | ||
a = ++foo; | ||
foo++; | ||
++foo; | ||
++a; | ||
a++; | ||
foo = a++; | ||
foo = ++a; | ||
} | ||
`; | ||
|
||
const output = babel.transformSync(code, { | ||
configFile: false, | ||
ast: false, | ||
plugins: [[plugin, { bindingNames: ["foo", "bar", "baz"] }]], | ||
}).code; | ||
|
||
expect(output).toMatchInlineSnapshot(` | ||
"var _foo, _bar; | ||
|
||
let a = (_foo = +foo, foo = _foo + 1, _foo); | ||
a = foo = +foo + 1; | ||
foo = foo + 1; | ||
foo = foo + 1; | ||
++a; | ||
a++; | ||
foo = a++; | ||
foo = ++a; | ||
let b = (_bar = +bar, bar = _bar - 1, _bar); | ||
b = bar = +bar - 1; | ||
bar = bar - 1; | ||
bar = bar - 1; | ||
--b; | ||
b--; | ||
bar = b--; | ||
bar = --b; | ||
let c = baz = baz + 1; | ||
baz = baz + 1; | ||
c += 1; | ||
|
||
function f() { | ||
let foo = 1; | ||
let a = foo++; | ||
a = ++foo; | ||
foo++; | ||
++foo; | ||
++a; | ||
a++; | ||
foo = a++; | ||
foo = ++a; | ||
}" | ||
`); | ||
}); | ||
|
||
it("simplifyAccess with includeUpdateExpression=false", function () { | ||
const code = ` | ||
let a = foo++; | ||
a = ++foo; | ||
foo++; | ||
++foo; | ||
++a; | ||
a++; | ||
foo = a++; | ||
foo = ++a; | ||
|
||
let b = bar--; | ||
b = --bar; | ||
bar--; | ||
--bar; | ||
--b; | ||
b--; | ||
bar = b--; | ||
bar = --b; | ||
|
||
let c = baz += 1; | ||
baz += 1; | ||
c += 1; | ||
|
||
function f() { | ||
let foo = 1; | ||
let a = foo++; | ||
a = ++foo; | ||
foo++; | ||
++foo; | ||
++a; | ||
a++; | ||
foo = a++; | ||
foo = ++a; | ||
} | ||
`; | ||
|
||
const output = babel.transformSync(code, { | ||
configFile: false, | ||
ast: false, | ||
plugins: [ | ||
[ | ||
plugin, | ||
{ includeUpdateExpression: false, bindingNames: ["foo", "bar", "baz"] }, | ||
], | ||
], | ||
}).code; | ||
|
||
expect(output).toMatchInlineSnapshot(` | ||
"let a = foo++; | ||
a = ++foo; | ||
foo++; | ||
++foo; | ||
++a; | ||
a++; | ||
foo = a++; | ||
foo = ++a; | ||
let b = bar--; | ||
b = --bar; | ||
bar--; | ||
--bar; | ||
--b; | ||
b--; | ||
bar = b--; | ||
bar = --b; | ||
let c = baz = baz + 1; | ||
baz = baz + 1; | ||
c += 1; | ||
|
||
function f() { | ||
let foo = 1; | ||
let a = foo++; | ||
a = ++foo; | ||
foo++; | ||
++foo; | ||
++a; | ||
a++; | ||
foo = a++; | ||
foo = ++a; | ||
}" | ||
`); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{ "type": "module" } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone accidentally updates
@babel/helper-simple-access
without also updating@babel/helper-module-transforms
(this is a valid thing to do, according to the semver dependency versions), I fear that this will break their current code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
What can I do? Should I bump the version of the package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because we keep all the versions synchronized (and it would require a major bump).
It's annoying, but a solution until Babel 8 is to pass a
includeUpdateExpression: boolean = true
option tosimplifyAccess
, and only skip theUpdateExpression
visitor when that option is set tofalse
.