Build ci on windows #14463
Merged
Build ci on windows #14463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51674/ |
liuxingbaoyu
force-pushed
the
build-ci-on-windows
branch
from
640f6e0
to
11ed54d
Compare
|
@nicolo-ribaudo @JLHwung Now it's passable! |
| @@ -96,6 +96,32 @@ jobs: | |||
| packages/babel-standalone/*.js | |||
| !**/node_modules/** | |||
|
|
|||
| build-windows: | |||
| name: Build Babel Artifacts On Windows | |||
| runs-on: windows-latest | |||
There was a problem hiding this comment.
Suggested change
| runs-on: windows-latest | |
| runs-on: windows-latest | |
| needs: prepare-yarn-cache |
so that it downloads the cached packages from the previous step.
There was a problem hiding this comment.
Ehh, it won't restore from that step anyway. The actions/setup-node generates different cache id from different os
https://github.com/actions/setup-node/blob/146c4d84a51256d5571b40011b76c0c6f7dfd981/src/cache-restore.ts#L39
even if Yarn 3 does support cache created from different OS.
nicolo-ribaudo
approved these changes
Apr 19, 2022
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14461
#14462
Need to wait for the two pull requests to be merged.
The new ci will prevent the problems of the above two pull requests.