Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build ci on windows #14463

Merged
merged 3 commits into from Apr 20, 2022
Merged

Build ci on windows #14463

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25162dc
build ci on windows
liuxingbaoyu Apr 13, 2022
c1de433
remove dep
liuxingbaoyu Apr 13, 2022
11ed54d
fix
liuxingbaoyu Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -96,6 +96,32 @@ jobs:
packages/babel-standalone/*.js
!**/node_modules/**

build-windows:
name: Build Babel Artifacts On Windows
runs-on: windows-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runs-on: windows-latest
runs-on: windows-latest
needs: prepare-yarn-cache

so that it downloads the cached packages from the previous step.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ehh, it won't restore from that step anyway. The actions/setup-node generates different cache id from different os
https://github.com/actions/setup-node/blob/146c4d84a51256d5571b40011b76c0c6f7dfd981/src/cache-restore.ts#L39
even if Yarn 3 does support cache created from different OS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok

# Yarn PnP does not support native ESM yet (https://github.com/yarnpkg/berry/issues/638)
# env:
# YARN_NODE_LINKER: pnp # use pnp linker for better linking performance and stricter checks
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Use Node.js latest
uses: actions/setup-node@v3
with:
node-version: "*"
cache: "yarn"
- name: Build babel artifacts
shell: bash
run: |
BABEL_ENV=test-legacy make -j build-standalone-ci
env:
BABEL_8_BREAKING: false
STRIP_BABEL_8_FLAG: true
- name: Ensure cwd does not contain uncommitted changes
shell: bash
run: |
./scripts/assert-dir-git-clean.sh

lint:
name: Lint
needs: build
Expand Down