Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _guessExecutionStatusRelativeToDifferentFunctions perf #14617

Merged
merged 2 commits into from Jun 8, 2022
Merged

Fix _guessExecutionStatusRelativeToDifferentFunctions perf #14617

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d0ee97
fix
liuxingbaoyu May 30, 2022
b82baf7
fix
liuxingbaoyu May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
58 changes: 48 additions & 10 deletions packages/babel-traverse/src/path/introspection.ts
View file
Open in desktop
Expand Up @@ -413,9 +413,9 @@ export function _guessExecutionStatusRelativeTo(
// function f() { if (false) f(); }
// f();
// It also works with indirect recursion.
const executionOrderCheckedNodes = new WeakSet();
const executionOrderCheckedNodes = new Set();

export function _guessExecutionStatusRelativeToDifferentFunctions(
function _guessExecutionStatusRelativeToDifferentFunctionsInternal(
this: NodePath,
target: NodePath,
): RelativeExecutionStatus {
Expand Down Expand Up @@ -455,21 +455,59 @@ export function _guessExecutionStatusRelativeToDifferentFunctions(
// Prevent infinite loops in recursive functions
if (executionOrderCheckedNodes.has(path.node)) continue;
executionOrderCheckedNodes.add(path.node);
try {
const status = this._guessExecutionStatusRelativeTo(path);

const status = this._guessExecutionStatusRelativeTo(path);

executionOrderCheckedNodes.delete(path.node);

if (allStatus && allStatus !== status) {
return "unknown";
} else {
allStatus = status;
if (allStatus && allStatus !== status) {
return "unknown";
} else {
allStatus = status;
}
} finally {
executionOrderCheckedNodes.delete(path.node);
}
}

return allStatus;
}

let executionStatusCache: Map<
NodePath["node"],
Map<NodePath["node"], RelativeExecutionStatus>
>;

export function _guessExecutionStatusRelativeToDifferentFunctions(
this: NodePath,
target: NodePath,
): RelativeExecutionStatus {
const inited = !!executionStatusCache;
if (!inited) {
executionStatusCache = new Map();
}

try {
let nodeMap = executionStatusCache.get(this.node);
if (!nodeMap) {
executionStatusCache.set(this.node, (nodeMap = new Map()));
} else if (nodeMap.has(target.node)) {
return nodeMap.get(target.node);
}

const result =
_guessExecutionStatusRelativeToDifferentFunctionsInternal.call(
this,
target,
);

nodeMap.set(target.node, result);
return result;
} finally {
if (!inited) {
executionStatusCache = undefined;
}
}
}

/**
* Resolve a "pointer" `NodePath` to it's absolute path.
*/
Expand Down