New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[babel 8] Other Babel 8 misc changes #15576
[babel 8] Other Babel 8 misc changes #15576
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54333/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the breaking changes of this PR are:
- Stop supporting presets/plugins with named exports, essentially reverting Resolve presets with named exports correctly #4620
- Per package renames, the
includes
andexcludes
preset-env
options will now only respect new plugin names
Other changes like removing the compat code for legacy helpers are not actually breaking. Did I miss any breaking changes?
@JLHwung That's correct 👍 All the other changes are just internal changes. |
function escape(code: number) { | ||
let str = code.toString(16); | ||
// Sigh, node 6 doesn't have padStart | ||
// TODO: Remove in Babel 8, when we drop node 6. | ||
while (str.length < 4) str = "0" + str; | ||
return "\\u" + str; | ||
if (process.env.BABEL_8_BREAKING) { | ||
return "\\u" + code.toString(16); | ||
} else { | ||
let str = code.toString(16); | ||
// Sigh, node 6 doesn't have padStart | ||
// TODO: Remove in Babel 8, when we drop node 6. | ||
while (str.length < 4) str = "0" + str; | ||
return "\\u" + str; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've made a mistake, but it seems the tests don't cover it.
0fbe4b8
to
6ff7197
Compare
These are almost all the remaining
TODO(Babel 8)
comments :)What remains to do (in other PRs):
2023-05
#15570noNewArrow
assumption to default tofalse
(I now think we shouldn't if they are still compiled by our default targets)babel/packages/babel-traverse/src/path/introspection.ts
Line 337 in fe42965