Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable transform-block-scoping with generators feature (#12806) #15606

Merged

Conversation

IlyaSemenov
Copy link
Contributor

@IlyaSemenov IlyaSemenov commented May 2, 2023

Q                       A
Fixed Issues? Workaround for #12806
Patch: Bug Fix? 👍
Major: Breaking Change? -
Minor: New Feature? -
Tests Added + Pass? 👍
Documentation PR Link -
Any Dependency Changes? -
License MIT

This adds generators to transform-block-scoping features:

"transform-block-scoping": {
features: ["const", "let"],
},

as asked by @nicolo-ribaudo in #12806, and adds a regression test for Chrome 49 preset.

@babel-bot
Copy link
Collaborator

babel-bot commented May 2, 2023

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54379/

@IlyaSemenov
Copy link
Contributor Author

I am not sure why the tests wouldn't pass. It's like it's ignoring the new compat-data. 🤷

@JLHwung
Copy link
Contributor

JLHwung commented May 2, 2023

Can you also update packages/babel-compat-data/data/plugin-bugfixes.json? I believe that is why CI is failing.

@IlyaSemenov IlyaSemenov force-pushed the fix/generators-block-scoping-12806 branch from 0b87763 to e0f7f69 Compare May 3, 2023 11:05
@IlyaSemenov
Copy link
Contributor Author

Updated. It passes all tests locally with make test-only and yarn jest --ci, but still fails some CI checks.

@nicolo-ribaudo
Copy link
Member

I updated the Babel 8 tests, hopefully CI will be green now :)

@nicolo-ribaudo nicolo-ribaudo merged commit 6c182cd into babel:main May 8, 2023
54 checks passed
@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label May 8, 2023
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants