Improve the type definition of path.isX
#15661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxingbaoyu
added
pkg: traverse
PR: Polish 💅
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54975/ |
liuxingbaoyu
commented
May 28, 2023
| @@ -201,6 +210,7 @@ export function isForAwaitStatement(this: NodePath): boolean { | |||
| return isForOfStatement(this.node, { await: true }); | |||
| } | |||
|
|
|||
| // TODO: Remove in Babel 8 | |||
| export function isExistentialTypeParam(this: NodePath): void { | |||
| throw new Error( | |||
| "`path.isExistentialTypeParam` has been renamed to `path.isExistsTypeAnnotation()` in Babel 7.", | |||
There was a problem hiding this comment.
Let's remove it now?
There was a problem hiding this comment.
Yeah we can use something like
babel/packages/babel-core/src/index.ts
Lines 84 to 88 in 9ca034f
| @@ -26,66 +26,75 @@ import type * as t from "@babel/types"; | |||
| const { isCompatTag } = react; | |||
| import type { VirtualTypeAliases } from "./virtual-types"; | |||
|
|
|||
| type Opts<Object> = Partial<{ | |||
There was a problem hiding this comment.
Nit, can you call this Obj to avoid confusion with the global Object constructor?
| @@ -26,66 +26,75 @@ import type * as t from "@babel/types"; | |||
| const { isCompatTag } = react; | |||
| import type { VirtualTypeAliases } from "./virtual-types"; | |||
|
|
|||
| type Opts<Object> = Partial<{ | |||
| [Prop in keyof Object]: Object[Prop] extends t.Node | |||
| ? t.Node | Object[Prop] | |||
There was a problem hiding this comment.
If Object[Prop] extends t.Node, isn't this union just t.Node?
nicolo-ribaudo
approved these changes
Jul 31, 2023
JLHwung
approved these changes
Jul 31, 2023
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2Ref: #15549