Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use NodePath#hub as part of the paths cache key" #15754

Merged
merged 1 commit into from Jul 6, 2023

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 6, 2023

Reverts #15725. This commit probably caused #15752.

@nicolo-ribaudo nicolo-ribaudo merged commit c1fe357 into main Jul 6, 2023
26 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the revert-15725-fix-hub-cach branch July 6, 2023 12:15
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54796/

@nicolo-ribaudo
Copy link
Member Author

Before re-landing this I'll add an e2e test for @angular/cli, so that we avoid breaking it so badly in the future. I plan to just make it run the steps listed in angular/angular-cli#25496 (comment) (basically, build an new Angular project).

@alan-agius4 do you think there is a better way to test Babel on Angular other than just building the starter project?

@alan-agius4
Copy link

@nicolo-ribaudo, generating and building a starter project is definitely the most straight forward way.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse PR: Revert ↩️ A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants