Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pure comments missing parentheses #16104

Merged
merged 3 commits into from Nov 18, 2023
Merged

fix: Pure comments missing parentheses #16104

merged 3 commits into from Nov 18, 2023

Conversation

liuxingbaoyu
Copy link
Member

Q                       A
Fixed Issues? Fixes #14797
Patch: Bug Fix? √
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? √
Documentation PR Link
Any Dependency Changes?
License MIT

@liuxingbaoyu liuxingbaoyu added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator area: comments labels Nov 15, 2023
@babel-bot
Copy link
Collaborator

babel-bot commented Nov 15, 2023 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55832/

JLHwung
JLHwung reviewed Nov 15, 2023
View reviewed changes
packages/babel-generator/src/printer.ts Outdated
forceParens ||
(format.retainFunctionParens &&
nodeType === "FunctionExpression" &&
node.extra?.parenthesized) ||
needsParens(node, parent, this._printStack);

if (
!shouldPrintParens &&
parent?.type === "MemberExpression" &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't have to limit the parent type. If there are leading comments and the node is parenthesized, it suggests that users intend to keep comments within the parentheses. Examples are

(/* @__PURE__ */ f())()
(/* @__PURE__ */ f())?.bar
(/* @__PURE__ */ f())`bar`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    -       var c = /*#__PURE__*/function () {
    +       var c = ( /*#__PURE__*/function () {

    -       setTimeout( /*#__PURE__*/function () {
    +       setTimeout(( /*#__PURE__*/function () {

Unfortunately there are some unexpected situations.

Updated: I added new logic to solve this problem.

@JLHwung JLHwung merged commit 4e38aa5 into babel:main Nov 18, 2023
48 checks passed
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Nov 20, 2023
Closed
1 task
This was referenced Nov 20, 2023
Merged
Merged
Vylpes pushed a commit to Vylpes/random-bunny that referenced this pull request Dec 4, 2023
@Vylpes
Update dependency @babel/traverse to v7.23.5 (#113)
5a6c9ed 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@babel/traverse](https://babel.dev/docs/en/next/babel-traverse) ([source](https://github.com/babel/babel)) | resolutions | patch | [`7.23.3` -> `7.23.5`](https://renovatebot.com/diffs/npm/@babel%2ftraverse/7.23.3/7.23.5) |

---

### Release Notes

<details>
<summary>babel/babel (@&#8203;babel/traverse)</summary>

### [`v7.23.5`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7235-2023-11-29)

[Compare Source](babel/babel@v7.23.4...v7.23.5)

##### 👓 Spec Compliance

-   `babel-plugin-proposal-decorators`
    -   [#&#8203;16138](babel/babel#16138) Class binding is in TDZ during decorators initialization ([@&#8203;nicolo-ribaudo](https://github.com/nicolo-ribaudo))
-   `babel-helpers`, `babel-plugin-proposal-decorators`
    -   [#&#8203;16132](babel/babel#16132) Allow addInitializer in field decorator context ([@&#8203;JLHwung](https://github.com/JLHwung))

##### 🐛 Bug Fix

-   `babel-traverse`, `babel-types`
    -   [#&#8203;16131](babel/babel#16131) Do not remove bindings when removing assignment expression path ([@&#8203;nicolo-ribaudo](https://github.com/nicolo-ribaudo))
-   `babel-plugin-transform-classes`
    -   [#&#8203;16135](babel/babel#16135) Require class properties transform when compiling class with private fields ([@&#8203;nicolo-ribaudo](https://github.com/nicolo-ribaudo))
-   `babel-generator`
    -   [#&#8203;16122](babel/babel#16122) fix: Missing parentheses after line break ([@&#8203;liuxingbaoyu](https://github.com/liuxingbaoyu))
-   `babel-helpers`
    -   [#&#8203;16130](babel/babel#16130) Fix helpers internal fns names conflict resolution  ([@&#8203;nicolo-ribaudo](https://github.com/nicolo-ribaudo))
-   `babel-helper-create-class-features-plugin`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-typescript`
    -   [#&#8203;16123](babel/babel#16123) Simplify class fields injetion after `super()` ([@&#8203;nicolo-ribaudo](https://github.com/nicolo-ribaudo))
-   `babel-generator`, `babel-plugin-transform-modules-commonjs`, `babel-plugin-transform-parameters`, `babel-plugin-transform-typescript`, `babel-traverse`
    -   [#&#8203;16110](babel/babel#16110) fix: Unexpected duplication of comments ([@&#8203;liuxingbaoyu](https://github.com/liuxingbaoyu))
-   `babel-eslint-plugin`
    -   [#&#8203;16023](babel/babel#16023) Add `@babel/eslint-plugin/no-undef` to fix `no-undef` with accessor props ([@&#8203;nicolo-ribaudo](https://github.com/nicolo-ribaudo))

##### 🔬 Output optimization

-   `babel-helpers`
    -   [#&#8203;16129](babel/babel#16129) Optimize `decorator` helper size ([@&#8203;liuxingbaoyu](https://github.com/liuxingbaoyu))

### [`v7.23.4`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7234-2023-11-20)

[Compare Source](babel/babel@v7.23.3...v7.23.4)

##### 🐛 Bug Fix

-   `babel-generator`
    -   [#&#8203;16104](babel/babel#16104) fix: Pure comments missing parentheses ([@&#8203;liuxingbaoyu](https://github.com/liuxingbaoyu))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=-->

Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/random-bunny/pulls/113
Reviewed-by: Vylpes <ethan@vylpes.com>
Co-authored-by: Renovate Bot <renovate@vylpes.com>
Co-committed-by: Renovate Bot <renovate@vylpes.com>
@liuxingbaoyu liuxingbaoyu mentioned this pull request Dec 11, 2023
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@AnimeshRy AnimeshRy AnimeshRy approved these changes

Assignees
No one assigned
Labels
area: comments outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Pure annotations are incorrectly modified to wrong scope
5 participants
@liuxingbaoyu @babel-bot @JLHwung @nicolo-ribaudo @AnimeshRy