Generate names field for identifiers to get correct names mappings #3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,7 +34,7 @@ export default class SourceMap { | |||
| * values to insert a mapping to nothing. | |||
| */ | |||
|
|
|||
| mark(generatedLine: number, generatedColumn: number, line: number, column: number, filename: ?string) { | |||
| mark(generatedLine: number, generatedColumn: number, line: number, column: number, identifierName: ?string, filename: ?string) { | |||
There was a problem hiding this comment.
Getting max-len error here (do we still want this on), I'd be ok with removing as well)
|
Very cool, maybe a test for the sourcemap https://github.com/babel/babel/blob/master/packages/babel-generator/test/index.js if that's straightforward |
hzoo
added
the
PR: New Feature 🚀
sebmck
force-pushed
the
identifier-name
branch
2 times, most recently
from
752d829
to
ee83dc1
Compare
sebmck
force-pushed
the
identifier-name
branch
from
ee83dc1
to
cc52e8b
Compare
|
👍 |
Current coverage is 89.69% (diff: 100%)@@ master #3658 diff @@
==========================================
Files 191 191
Lines 13582 17452 +3870
Methods 1423 2063 +640
Messages 0 0
Branches 3127 4739 +1612
==========================================
+ Hits 11981 15654 +3673
- Misses 1601 1798 +197
Partials 0 0
|
Timer
added a commit
to Timer/source-list-map
that referenced
this pull request
Dec 1, 2016
Timer
added a commit
to Timer/source-list-map
that referenced
this pull request
Dec 1, 2016
|
Caused an issue with webpack sourcemaps but was fixed - webpack/source-list-map#2 |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows things like name mangling to retain their original source location and allows debuggers to do realiasing etc.