Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore sourcemaps names #2

Merged
merged 1 commit into from Dec 2, 2016
Merged

Conversation

Marsup
Copy link
Contributor

@Marsup Marsup commented Aug 29, 2016

Hi,

Since babel landed their 6.4 version, our project is having difficulties getting correct sourcemaps, breakpoints not stopping, console.log pointing to undefined webpack files, ...

It seems the addition of names into the sourcemaps (babel/babel#3658) which adds an extra character is unsupported by this module. I went for a really quick and dumb fix, which is to completely ignore the extra character, but maybe someone could give me some guidance about supporting it if it's desired ?

Regards.

@Marsup
Copy link
Contributor Author

Marsup commented Sep 2, 2016

Anyone from the @webpack org to help me land this ? At least as a temporary band-aid until you decide to support names.

@romain-h
Copy link

We are facing the same issue with console.log pointing to undefined Webpack files. I quickly tried this patch and it seems to fix it.

Nice catch @Marsup regarding this extra character.

@Marsup
Copy link
Contributor Author

Marsup commented Oct 19, 2016

Well thanks but sadly it's been ignored for nearly 2 months now :(

@Timer Timer mentioned this pull request Dec 1, 2016
@sokra sokra merged commit e7d150b into webpack:master Dec 2, 2016
@sokra
Copy link
Member

sokra commented Dec 2, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants