Replace phabricator tickets with github ones in code comments #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.32% (diff: 100%)
|
|
Ok yeah go ahead |
hzoo
approved these changes
Sep 18, 2016
| @@ -1,4 +1,4 @@ | |||
| // T6809 | |||
| // #3861 | |||
There was a problem hiding this comment.
Maybe this should just be in the folder structure
| @@ -212,7 +212,7 @@ export function requeue(pathToQueue = this) { | |||
| if (pathToQueue.removed) return; | |||
|
|
|||
| // TODO(loganfsmyth): This should be switched back to queue in parent contexts | |||
| // automatically once T2892 and T7160 have been resolved. See T7166. | |||
| // automatically once #2892 and #4135 have been resolved. See #4140. | |||
There was a problem hiding this comment.
Might want to make issues for these instead of just TODOs
hzoo
added
the
PR: Internal 🏠
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should I also change the links in the Changelog?