Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace phabricator tickets with github ones in code comments #4519

Merged
merged 1 commit into from Sep 18, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -1,4 +1,4 @@
// T6809
// #3861
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should just be in the folder structure

function t(x = "default", { a, b }, ...args) {
console.log(x, a, b, args);
}
@@ -1,4 +1,4 @@
// T6809
// #3861
function t() {
var x = arguments.length <= 0 || arguments[0] === undefined ? "default" : arguments[0];
var _ref = arguments[1];
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-traverse/src/path/context.js
Expand Up @@ -212,7 +212,7 @@ export function requeue(pathToQueue = this) {
if (pathToQueue.removed) return;

// TODO(loganfsmyth): This should be switched back to queue in parent contexts
// automatically once T2892 and T7160 have been resolved. See T7166.
// automatically once #2892 and #4135 have been resolved. See #4140.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to make issues for these instead of just TODOs

// let contexts = this._getQueueContexts();
let contexts = this.contexts;

Expand Down
2 changes: 1 addition & 1 deletion packages/babel-traverse/src/path/modification.js
Expand Up @@ -50,7 +50,7 @@ export function _containerInsert(from, nodes) {

// While this path may have a context, there is currently no guarantee that the context
// will be the active context, because `popContext` may leave a final context in place.
// We should remove this `if` and always push once T7171 has been resolved.
// We should remove this `if` and always push once #4145 has been resolved.
if (this.context.queue) path.pushContext(this.context);
paths.push(path);
} else {
Expand Down