Retain method return types on transform-es2015-classes (closes #4665) #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
approved these changes
Oct 4, 2016
|
Hmm - overlooked obviously. 👍 😄 I wonder how we can prevent this issue from happening in the future? This is because babel.types constructor doesn't take in all fields and types wouldn't be in there. Would be nice if we had a way to lint that the information from the previous node wasn't carried over |
hzoo
added
the
PR: Bug Fix 🐛
Current coverage is 88.76% (diff: 100%)@@ master #4668 diff @@
==========================================
Files 195 195
Lines 13776 13778 +2
Methods 1425 1425
Messages 0 0
Branches 3174 3174
==========================================
+ Hits 12228 12230 +2
Misses 1548 1548
Partials 0 0
|
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-attaches return types when converting
ClassMethodtoFunctionExpression.Added tests for loose & spec class transforms, with normal output,
flow-comments&flow-strip-types.