Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect compilation of async iterator methods #4719

Merged
merged 1 commit into from Oct 14, 2016
Merged

Fixed incorrect compilation of async iterator methods #4719

merged 1 commit into from Oct 14, 2016

Conversation

Jamesernator
Copy link
Contributor

Q A
Bug fix? yes
Breaking change? yes for spec compliancy
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? changed 3 tests for spec compliancy
Fixed tickets 4705
License MIT
Doc PR n/a

This pull request is to fix an issue with how async generators are implemented in methods/objects/state methods to actually result in correct behaviour (see #4705). This closes #4705.

@codecov-io
Copy link

Current coverage is 88.83% (diff: 100%)

No coverage report found for master at 09f135f.

Powered by Codecov. Last update 09f135f...e046bb1

Copy link
Member

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I'm not 100% into the async iteration transform, but this seems correct.

@danez danez added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Oct 13, 2016
@hzoo hzoo merged commit dc4140d into babel:master Oct 14, 2016
@hzoo
Copy link
Member

hzoo commented Oct 14, 2016

cc @domenic (should of earlier)

@domenic
Copy link

domenic commented Oct 14, 2016

Seems good to me :)

chrisprice pushed a commit to chrisprice/babel that referenced this pull request Oct 18, 2016
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async iterator methods don't work in babel-preset-stage-3
5 participants