Run ESLint on test files, and fix lint errors in test files. #4732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrewML
changed the title
Current coverage is 88.81% (diff: 100%)@@ master #4732 diff @@
==========================================
Files 195 195
Lines 13826 13826
Methods 1428 1428
Messages 0 0
Branches 3187 3187
==========================================
Hits 12280 12280
Misses 1546 1546
Partials 0 0
|
hzoo
reviewed
Oct 15, 2016
| @@ -1,5 +1,13 @@ | |||
| { | |||
| "extends": "babel", | |||
| "globals": { | |||
| "test": true, | |||
There was a problem hiding this comment.
Would these be covered with the mocah env for globals?
There was a problem hiding this comment.
Ooohh, good call. Pushed the change
hzoo
reviewed
Oct 15, 2016
| 'var x = function x(y) {', | ||
| ' return y;', | ||
| '};' | ||
| "\"use strict\";", |
There was a problem hiding this comment.
We can totally use template strings here (different pr)
|
Awesome this is great! First PR! 🎉 |
hzoo
added
the
PR: Internal 🏠
chrisprice
pushed a commit
to chrisprice/babel
that referenced
this pull request
Oct 18, 2016
mstade
added a commit
to zambezi/babel
that referenced
this pull request
Oct 28, 2016
* master: (38 commits) chore(package): update browserify to version 13.1.1 (babel#4762) Increase test coverage (babel#4742) Make getBinding ignore labels; add Scope#getLabel, Scope#registerLabel (babel#4758) Add variance node type and generate property variance annotations (babel#4697) Add make command to delete node_modules (babel#4748) fixes [skip ci] Support ObjectExpression in static path evaluation (babel#4746) Fix replacing for-of if inside label (babel#4736) Replace `path-exists` with `fs.existsSync` (babel#4731) Avoid unnecessary +0 in transform-es2015-parameters (babel#4738) [import()] Initial support for dynamic-import (babel#4699) Fix line endings on checkout Automatically generate missing expected.js fixtures (babel#4735) Fix few typos in issue/pr templates (babel#4739) [skip ci] contributing updates [skip ci] increase git depth [skip ci] Change usage of "suite"/"test" in unit-tests to "describe"/"it" (babel#4734) Run ESLint on test files, and fix lint errors in test files (babel#4732) Add .gitattributes forcing LF line endings (babel#4730) Update tests for changed error messages in Babylon (babel#4727) ...
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4714. Updated ESLint globbing patterns in the
makefileto run overtestfolders now underpackages, in addition tosrc. Also ran--fixto autofix a bunch of errors, and manually fixed the few that aren't autofixable.This change includes adding
some globalsnew env (mocha) globals to be ignored in.eslintrc. I should note that this will treat those identifiers as globals in all files, not just test files. The alternative to this would be to drop a.eslintrcin every test directory, or add an ignore comment to the top of each test file, but that seems like it would be a pain longterm.