Ensure array is always copied during destructure #5093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
existentialism
commented
Jan 11, 2017
existentialism
commented
| Q | A |
|---|---|
| Patch: Bug Fix? | Y |
| Major: Breaking Change? | N |
| Minor: New Feature? | N |
| Deprecations? | N |
| Spec Compliancy? | N |
| Tests Added/Pass? | Y |
| Fixed Tickets | Fixes #5090 |
| License | MIT |
| Doc PR | |
| Dependency Changes |
|
Hey @existentialism! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time. OS: linux |
|
lol fun it works! Also regarding the code it seems it was intentional lol? |
Current coverage is 89.20% (diff: 100%)@@ master #5093 diff @@
==========================================
Files 203 203
Lines 9817 9816 -1
Methods 1071 1071
Messages 0 0
Branches 2613 2612 -1
==========================================
- Hits 8757 8756 -1
Misses 1060 1060
Partials 0 0
|
|
Wow, bug fixed by removing a conditional? That's the best kind of fix! 😸 |
xtuc
approved these changes
Jan 15, 2017
existentialism
added
the
PR: Bug Fix 🐛
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.