Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure array is always copied during destructure #5093

Merged
merged 2 commits into from Jan 15, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -294,10 +294,7 @@ export default function ({ types: t }) {

if (t.isRestElement(elem)) {
elemRef = this.toArray(arrayRef);

if (i > 0) {
elemRef = t.callExpression(t.memberExpression(elemRef, t.identifier("slice")), [t.numericLiteral(i)]);
}
elemRef = t.callExpression(t.memberExpression(elemRef, t.identifier("slice")), [t.numericLiteral(i)]);

// set the element to the rest element argument since we've dealt with it
// being a rest already
Expand Down
@@ -0,0 +1,9 @@
const assign = function([...arr], index, value) {
arr[index] = value;
return arr;
}

const arr = [1, 2, 3];
assign(arr, 1, 42);

assert.deepEqual(arr, [1, 2, 3]);