Add @babel/plugin-transform-named-capturing-groups-regex #7105

nicolo-ribaudo · 2017-12-25T21:35:37Z

Q	A
Fixed Issues?	babel/proposals#35
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?	yes
Tests Added + Pass?	Yes
Documentation PR
Any Dependency Changes?	`regexp-tree`
License	MIT

When the runtime flag is on, this plugin adds a new helper which wraps the native RegExp class to provide groups support. People nees to use a polyfill (I implemented it in core-js) for browsers that don't support overwriting regexp methods.

nicolo-ribaudo · 2017-12-25T21:44:11Z

...ransform-named-capturing-groups-regex/test/fixtures/syntax/.escape-no-unicode-flag/actual.js

@@ -0,0 +1 @@
+/(?<\u{41}>)\k<\u{41}>/;


@DmitrySoshnikov I think that regexp-tree should throw on this regex, since unicode escapes are only alloed when there is the u flag?

Yeah, @Golmote added generic support for Unicode to parser (DmitrySoshnikov/regexp-tree#114); we should also check the group names, if they are allowed only with u flag (since by itself \u{41} can normally be used without u flag -- "u repeated 41 times").

If you're positive from spec, that it should throw, we should open an issue. Thanks for catching it!

I'm pretty sure identity escapes don't throw without the u flag.

@Golmote, right, however this one is specifically for a capturing group name, like in (?<\u{41}>). I'll need to double-check the spec, but seems, yes, it should throw, and be an invalid name for a group if no u flag is passed.

Sorry I read too fast 😳

babel-bot · 2017-12-25T21:44:16Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9800/

xtuc · 2017-12-27T16:45:30Z

packages/babel-plugin-transform-named-capturing-groups-regex/package.json

+    "regexp",
+    "regular expressions"
+  ],
+  "repository": "https://github.com/babel/babel/tree/master/packages/babel-plugin-transform-named-capturing-groups-regex.git",


Can you please remove the .git as the end here?

nicolo-ribaudo · 2018-01-02T22:15:05Z

The tests are failing because regexp-tree only works on node >= 6.
@mathiasbynens I will work on implementing named groups in regexpu-core (I already opened the parser PR some days ago: jviereck/regjsparser#83)

DmitrySoshnikov · 2018-01-03T05:36:24Z

The tests are failing because regexp-tree only works on node >= 6.

Thanks for the notice! Just an FYI, I removed node >= 6 restriction in 0.0.78, and now support older Node versions.

nicolo-ribaudo · 2018-01-23T21:35:01Z

Proposal merged - tc39/ecma262#1027 (comment)

Andarist · 2018-01-23T22:25:31Z

packages/babel-helpers/src/helpers.js

+    }, Object.create(null));
+  }
+
+  wrap(RegExp.prototype, "exec", function(f, str) {


This is effectful, I understand that it's hard (impossible?) to implement this feature without actually messing with built in prototypes - but when that is the case I feel like it should not be a part of babel-helpers, but rather babel-polyfill

@zloirock Does corejs polyfill support for [String.replace] and overwritten exec? If it does, we can remove thi "compat" helper from Babel.

@nicolo-ribaudo core-js supports @@replace, but does not overwrite exec.

Sorry, I didn't explain myself correctly. Every RegExp method (or string method which uses regexs) should use exec internally. e.g.

class MyRegExp extends RegExp { exec() { return ["foo", "bar"]; } } "abc".match(new MyRegExp("b")); // ["foo", "bar"]

If it doesn't work in core-js, I could open a PR

core-js provides a naive realisation of support RegExp-related well-known symbols and use original methods like String.prototype.match or String.prototype.replace. It's done for reducing slowdown in wrappers. However, now it should not cause too many problems, so feel free to add a PR with adding this logic.

Andarist · 2018-01-23T22:28:27Z

packages/babel-helpers/src/helpers.js

+helpers.wrapRegExp = defineHelper(`
+  var kGroups = Symbol("@@babel/groups");
+
+  function BabelRegExp(re, groups) {


could this be wrapped in an iife? all those assignments at the moment will prevent tree-shaking if BabelRegExp class stays unused. Im not sure if we can annotate helper as #__PURE__ at the moment though (I think comments in the helpers are ignored)

we could probably also use a redefining helper technique here to contain this whole declaration within a single top level node

it seems though that it would actually be cleaner if we could transpile helpers with user settings - this could be written as an actual class

DmitrySoshnikov · 2018-05-07T18:43:40Z

Is this PR ready to me merged?

damianobarbati · 2018-08-18T17:46:35Z

Can this be merged @nicolo-ribaudo ?

nicolo-ribaudo · 2018-08-18T18:49:45Z

It depends on

DmitrySoshnikov · 2018-09-25T23:46:29Z

Is this ready for merge?

nicolo-ribaudo · 2018-09-26T18:19:58Z

packages/babel-helpers/src/helpers.js

+      if (result) result.groups = buildGroups(result, this);
+      return result;
+    };
+    BabelRegExp.prototype[Symbol.replace] = function(str, substitution) {


I think that I will move this whole method to core-js (I already moved the first part)

Probably it is better to leave it there, otherwise even es6+ browsers require core-js

iheanyi · 2018-11-07T21:42:58Z

Any updates on this PR y'all?

existentialism · 2018-11-27T15:47:59Z

packages/babel-plugin-transform-named-capturing-groups-regex/src/index.js

+export default function({ types: t }, options) {
+  const { runtime = true } = options;
+  if (typeof runtime !== "boolean") {
+    throw new Error(".runtime must be boolean");


Nit: Is the period necessary?

existentialism · 2018-11-27T15:49:53Z

packages/babel-plugin-transform-named-capturing-groups-regex/package.json

+  "repository": "https://github.com/babel/babel/tree/master/packages/babel-plugin-transform-named-capturing-groups-regex",
+  "bugs": "https://github.com/babel/babel/issues",
+  "dependencies": {
+    "regexp-tree": "^0.0.78"


Should we bump to latest (85)?

Yes, let's use the latest version.

existentialism · 2018-11-27T15:51:41Z

This still needs zloirock/core-js#435 to be published, yea?

/cc: @zloirock

nicolo-ribaudo · 2018-11-27T16:01:16Z

Yeah, It hasn't been released yet.

zloirock · 2018-11-27T16:30:45Z

@existentialism we need a backport of zloirock/core-js#453 to v2 branch. I'll try to test it with v3 branch and publish a new beta release at this weak.

nicolo-ribaudo · 2018-11-27T17:35:07Z

Oh right, I will backport it.

nicolo-ribaudo · 2018-12-06T06:58:06Z

core-js was just updated, I'll update this PR soon.

existentialism

👍, I'll follow this up with preset-env support!

Thanks @zloirock for the support as well!

DmitrySoshnikov · 2019-01-15T05:29:44Z

@nicolo-ribaudo, what's the status on this? You can also update to the latest v. 0.1.0.

billyjanitsch · 2019-01-22T16:22:43Z

Wanted to cross-reference DmitrySoshnikov/regexp-tree#170. regexp-tree brings in a bunch of large CLI dependencies including an old version of yargs, which significantly increases the install size of @babel/preset-env (due to #9345). It would be great to have these moved to a separate CLI package, if possible.

cc @DmitrySoshnikov @existentialism

DmitrySoshnikov · 2019-01-22T19:17:07Z

@billyjanitsch, yes, we'll be separating the CLI (and potentially other modules) into its own npm package.

DmitrySoshnikov · 2019-02-18T03:58:32Z

Note: as of v1.1.5 the CLI is split into its own module, so the size of the regexp-tree is reduced significantly.

nicolo-ribaudo commented Dec 25, 2017

View reviewed changes

nicolo-ribaudo force-pushed the named-groups branch from 7920760 to f09188a Compare December 25, 2017 22:43

existentialism added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Dec 26, 2017

xtuc reviewed Dec 27, 2017

View reviewed changes

mathiasbynens approved these changes Jan 2, 2018

View reviewed changes

nicolo-ribaudo force-pushed the named-groups branch from 891eaf7 to 8c8bfa7 Compare January 15, 2018 20:20

Andarist reviewed Jan 23, 2018

View reviewed changes

aomarks mentioned this pull request Mar 16, 2018

Support all ES2016, ES2017 plugins and some ES2018. Polymer/polymer-build#313

Merged

1 task

existentialism mentioned this pull request May 8, 2018

Switch to updated decorators plugin in Babylon prettier/prettier#2630

Closed

DmitrySoshnikov mentioned this pull request May 22, 2018

Implement runtime support DmitrySoshnikov/babel-plugin-transform-modern-regexp#3

Open

r4j4h mentioned this pull request Jun 8, 2018

Regex named capture groups babel/proposals#35

Closed

nicolo-ribaudo force-pushed the named-groups branch from 8c8bfa7 to 5036877 Compare June 10, 2018 21:38

nicolo-ribaudo mentioned this pull request Jun 13, 2018

Make RegExp#[Symbol.*] methods call exec zloirock/core-js#411

Merged

DmitrySoshnikov mentioned this pull request Jun 29, 2018

Named group is not transformed DmitrySoshnikov/babel-plugin-transform-modern-regexp#7

Open

hzoo mentioned this pull request Jul 11, 2018

Move new Stage 4 proposals into preset-env #8304

Closed

9 tasks

DmitrySoshnikov mentioned this pull request Aug 24, 2018

Unexpected token DmitrySoshnikov/babel-plugin-transform-modern-regexp#8

Closed

nicolo-ribaudo force-pushed the named-groups branch 2 times, most recently from 304b365 to 1a2f8cb Compare September 13, 2018 08:21

nicolo-ribaudo commented Sep 26, 2018

View reviewed changes

nicolo-ribaudo force-pushed the named-groups branch from 1a2f8cb to 2ce3df0 Compare September 26, 2018 19:55

nicolo-ribaudo mentioned this pull request Sep 26, 2018

Polyfll named groups in RegExp#@@replace zloirock/core-js#435

Merged

nicolo-ribaudo force-pushed the named-groups branch from de260aa to 4bd414a Compare September 26, 2018 20:38

nicolo-ribaudo force-pushed the named-groups branch from 4bd414a to 492ce95 Compare November 26, 2018 20:31

existentialism reviewed Nov 27, 2018

View reviewed changes

nicolo-ribaudo force-pushed the named-groups branch from 492ce95 to c0014fe Compare December 7, 2018 10:20

existentialism approved these changes Dec 7, 2018

View reviewed changes

nicolo-ribaudo added 4 commits January 15, 2019 17:59

Add @babel/plugin-transform-named-capturing-groups-regex

05777b8

fix

e276e41

Review by @existentialism

1993f8a

Update version

ce8ff40

nicolo-ribaudo force-pushed the named-groups branch from 00dd8cd to ce8ff40 Compare January 15, 2019 17:05

nicolo-ribaudo merged commit a27b9b4 into babel:master Jan 15, 2019

nicolo-ribaudo deleted the named-groups branch January 15, 2019 17:21

nicolo-ribaudo mentioned this pull request Jan 15, 2019

Docs for @babel/plugin-transform-named-capturing-groups-regex babel/website#1946

Merged

existentialism mentioned this pull request Jan 15, 2019

Add support for transform-named-capturing-groups-regex in preset-env #9345

Merged

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019

		@@ -0,0 +1 @@
		/(?<\u{41}>)\k<\u{41}>/;

Add @babel/plugin-transform-named-capturing-groups-regex #7105

Add @babel/plugin-transform-named-capturing-groups-regex #7105

Conversation

nicolo-ribaudo commented Dec 25, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

babel-bot commented Dec 25, 2017 • edited

Choose a reason for hiding this comment

nicolo-ribaudo commented Jan 2, 2018

DmitrySoshnikov commented Jan 3, 2018

nicolo-ribaudo commented Jan 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DmitrySoshnikov commented May 7, 2018

damianobarbati commented Aug 18, 2018

nicolo-ribaudo commented Aug 18, 2018 • edited

DmitrySoshnikov commented Sep 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iheanyi commented Nov 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

existentialism commented Nov 27, 2018

nicolo-ribaudo commented Nov 27, 2018

zloirock commented Nov 27, 2018

nicolo-ribaudo commented Nov 27, 2018

nicolo-ribaudo commented Dec 6, 2018

existentialism left a comment • edited

Choose a reason for hiding this comment

DmitrySoshnikov commented Jan 15, 2019

billyjanitsch commented Jan 22, 2019

DmitrySoshnikov commented Jan 22, 2019

DmitrySoshnikov commented Feb 18, 2019 • edited

nicolo-ribaudo commented Dec 25, 2017 •

edited

babel-bot commented Dec 25, 2017 •

edited

nicolo-ribaudo commented Aug 18, 2018 •

edited

existentialism left a comment •

edited

DmitrySoshnikov commented Feb 18, 2019 •

edited