Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for transform-named-capturing-groups-regex in preset-env #9345

Merged
merged 2 commits into from Jan 18, 2019
Merged

Add support for transform-named-capturing-groups-regex in preset-env #9345

merged 2 commits into from Jan 18, 2019

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented Jan 15, 2019 •
edited

Q                       A
Fixed Issues?
Patch: Bug Fix? N
Major: Breaking Change? N
Minor: New Feature? Y
Tests Added + Pass? Y/Y
Documentation PR Link
Any Dependency Changes?
License MIT

Followup to #7105

@existentialism existentialism added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: preset-env labels Jan 15, 2019
nicolo-ribaudo
nicolo-ribaudo approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that was fast

@existentialism
Copy link
Member Author

@nicolo-ribaudo lol had it ready

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jan 15, 2019
Closed
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9803/

@DmitrySoshnikov
Copy link
Contributor

Looks good, thanks! 👍

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jan 15, 2019
Closed
3 tasks
@existentialism existentialism merged commit b92ad31 into master Jan 18, 2019
@existentialism existentialism deleted the env-named-rege branch January 18, 2019 01:51
@billyjanitsch billyjanitsch mentioned this pull request Jan 22, 2019
Merged
@jaredh159 jaredh159 mentioned this pull request May 3, 2019
Closed
5 tasks
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hzoo hzoo hzoo approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@existentialism @babel-bot @DmitrySoshnikov @hzoo @nicolo-ribaudo