Fix optional chaining bug regarding spread in function calls #8210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8452/ |
hzoo
added
Spec: Optional Chaining
PR: Bug Fix 🐛
hzoo
reviewed
Jun 22, 2018
| @@ -83,6 +83,10 @@ export default declare((api, options) => { | |||
| } | |||
| } | |||
|
|
|||
| if (replacementPath.isOptionalCallExpression()) { | |||
| replacementPath.node.type = "CallExpression"; | |||
There was a problem hiding this comment.
Looks good, the type should be changed in the transform for sure? This logic is similar to what was done in https://github.com/babel/babel/pull/8210/files#diff-accf2589ebb96f2b32131e0a1f8a08eaR24
if (objectPath.isOptionalMemberExpression()) {
objectPath.node.type = "MemberExpression";
}
hzoo
approved these changes
Jun 22, 2018
|
@hzoo Do you have an idea of when this PR will be merged & released ? I came across this issue using a spread operator into an optional chaining method call and the spread operator is invisible for |
Merged
|
Closing this for #9073, which fixes the more general case. I've reused your commits, so you'll still get credit. Thanks for starting it! |
|
@jridgewell thank you! |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
proposal-optional-chainingtransformsinto
that last
_a.b()is technically anOptionalCallExpressionwith nooptionalfield set.This PR changes it to be just a
CallExpression. I believe this is how it should be, and this also enables other plugins (liketransform-spread) who useCallExpressionin their visitors to keep working.