New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Smart Pipeline proposal in @babel/parser #8289
Merged
xtuc
merged 27 commits into
babel:master
from
valtech-nyc:implement-smart-pipeline-in-parser
Dec 3, 2018
Merged
Changes from 9 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
fbf62b4
Implement Smart Pipeline proposal in @babel/parser
js-choi ef0f723
Reverse yoda conditions
mAAdhaTTah b50fdc1
Inline function checkSmartPipelineHeadEarlyErrors
mAAdhaTTah 0084570
Add comment for number sign
mAAdhaTTah 7188820
Delete commented code
mAAdhaTTah cc52694
Quote proposals in error message
mAAdhaTTah e91a02c
Reuse declared type in function return value
mAAdhaTTah b847d40
Inline readTopicContextState method
mAAdhaTTah 7931f4c
Rename topicContextState -> .topicContext
mAAdhaTTah 6e41edb
Fix TopicContextState type in Flow
mAAdhaTTah afd0638
Reuse hash token instead of new primaryTopicToken
mAAdhaTTah 094ef31
Wrap callback in try/finally
mAAdhaTTah 39e7ee6
Switch Pipeline types to extend NodeBase
mAAdhaTTah 11aee13
Swap Yoda condition
mAAdhaTTah d1cae2d
Remove unneeded comment
mAAdhaTTah 15e6d84
Remove additional parser logic
mAAdhaTTah ba5642d
Add test for computer properties
mAAdhaTTah 25d0146
Fix error message for #4 case
mAAdhaTTah 122906d
Verify if MemberExpression is computed
mAAdhaTTah 4521204
Merge branch 'master' into implement-smart-pipeline-in-parser
mAAdhaTTah b593af1
Replace codePointToString with ES6 method
mAAdhaTTah a0e94ec
Move PipelineStyle to types.js file
mAAdhaTTah 0eb9b24
Move plugin check to pipeline op appearance
mAAdhaTTah 6e84352
PrimaryTopicReference -> PipelinePrimaryTopicReference
mAAdhaTTah 70318c9
s/may/should
mAAdhaTTah 4cbd22a
Hardcode "#" in error message
mAAdhaTTah 100b387
Replace else with fall through
mAAdhaTTah File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have pipelines proposal names as constants? Or even a high-level function:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constants would be nice, but the proposals are used both by
@babel/parser
& the plugin itself. Where should we put them so they can be shared?