@babel/parser(ts): Add parsing of type import #9302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9735/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9725/ |
|
build failed due to timeout |
|
@armano2 restarted! |
existentialism
added
area: typescript
PR: New Feature 🚀
|
@existentialism you guys have to fix developing on windows, this is killing me xd finally its finished xd |
hzoo
approved these changes
Jan 9, 2019
danez
reviewed
Jan 10, 2019
danez
reviewed
Jan 10, 2019
danez
approved these changes
Jan 10, 2019
|
Before we merge we should have the changes for generator ready. |
|
Thanks for following up on my PR 🙏 |
|
@danez Going to make a PR tomorrow! |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is continuation of work done in #8798 by @Kovensky few months ago.
This PR adds new node
TSImportType.Comparing to how TS parses this there is one difference
in typescript is represented by
ImportType[typeof=true]this implementation will parse it into:
TSTypeQuery[exprName='TSImportType']i can easily change that if you think it will be better.