Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@babel/parser(ts): Add parsing of type import #9302

Merged
merged 8 commits into from Jan 10, 2019
Merged

@babel/parser(ts): Add parsing of type import #9302

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d6857a2
Add prototype parser support for type-space import()
Jessidhia Oct 2, 2018
c8c88ab
Remove unneeded options.json
Jessidhia Oct 2, 2018
17b44ec
@babel/parser(ts): fix parsing import type
armano2 Jan 8, 2019
07b52b8
fix: correct type definition
armano2 Jan 8, 2019
9cf2bda
fix: do not break on whitespaces
armano2 Jan 9, 2019
43c782e
fix: apply suggestions from @nicolo-ribaudo
armano2 Jan 10, 2019
e37e013
chore: add nicer error message
armano2 Jan 10, 2019
d513535
chore: fix typo in error message
armano2 Jan 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/babel-parser/src/plugins/typescript.js
View file
Open in desktop
Expand Up @@ -225,7 +225,10 @@ export default (superClass: Class<Parser>): Class<Parser> =>
this.expect(tt._import);
this.expect(tt.parenL);
if (!this.match(tt.string)) {
throw this.unexpected();
throw this.unexpected(
null,
"Argument in a type import must be an string literal",
armano2 marked this conversation as resolved.
Show resolved Hide resolved
);
}
node.argument = this.parseLiteral(this.state.value, "StringLiteral");
this.expect(tt.parenR);
Expand Down