Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate sqlite driver switch to better-sqlite3 #9912

Closed
Rugvip opened this issue Mar 2, 2022 · 0 comments · Fixed by #10132
Closed

Investigate sqlite driver switch to better-sqlite3 #9912

Rugvip opened this issue Mar 2, 2022 · 0 comments · Fixed by #10132
Labels
backend enhancement New feature or request help wanted Help/Contributions wanted from community members

Comments

@Rugvip
Copy link
Member

Rugvip commented Mar 2, 2022

Feature Suggestion

Let's investigate whether better-sqlite3 is a better option than @vscode/sqlite3, which has been causing a lot of issues lately due to not providing binaries (#9734, #9622, #9583). Thanks to @benjdlambert's earlier work this is an option 🎉

Possible Implementation

Try out better-sqlite3, if it works out of the box or with somewhat minimal changes, then we likely want to switch over. We also want to make sure that we don't take a big performance hit by comparing the performance of the catalog across the two drivers.

Since SQLite is only intended for development we don't need to take DB file compatibility into account, but let's do give a heads up that an export/import might be needed if someone is relying on SQLite file storage.

Context

We're leaving this issue open for contributions as it is well isolated and a good opportunity for the community to help the project grow. Let us know if you want to pick this up, thank you! 🙏

#9351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request help wanted Help/Contributions wanted from community members
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant