Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump knex from 0.95.6 to 1.0.2 #9351

Merged
merged 2 commits into from Feb 8, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 4, 2022

Bumps knex from 0.95.6 to 1.0.2.

Release notes

Sourced from knex's releases.

1.0.1

Bug fixes:

  • Fix package.json metadata

1.0.0

Breaking changes

  • Dropped support for Node 10;
  • Replaced unsupported sqlite3 driver with @vscode/sqlite3;
  • Changed data structure from RETURNING operation to be consistent with SELECT;
  • Changed Migrator to return list of migrations as objects consistently.

New features:

  • Support fromRaw #4781
  • Support zero precision in timestamp/datetime #4784
  • Support whereLike and whereILike #4779
  • Add JSDoc (TS flavor) to stub files #4809
  • Allow skip binding in limit and offset #4811
  • Support creating a new table in the database based on another table #4821
  • Accept Raw on onIn joins #4830
  • Implement support for custom seed sources #4842
  • Add binary uuid option #4836
  • ForUpdate array parameter #4882
  • Add camel case to timestamps method #4803
  • Advanced JSON support #4859
  • Add type to TypeScript knexfile #4909
  • Checks Constraints Support #4874
  • Support creating multiple PKs with increments #4903
  • Enable wrapIdentifier for SQLite .hasTable #4915
  • MSSQL: Add support for unique constraint #4887
  • SQLite: New dialect, using better-sqlite3 driver #4871
  • SQLite: Switch to @​vscode/sqlite3 #4866
  • SQLite: Support createViewOrReplace #4856
  • SQLite: Support RETURNING statements for better-sqlite3 driver #4934
  • PostgreSQL: Support JOIN and USING syntax for Delete Statement #4800

Bug fixes:

  • Fix overzealous warning on use of whereNot with "in" or "between" #4780
  • Fix Union all + first syntax error #4799
  • Make view columns optional in create view like #4829
  • Insert lock row fix during migration #4865
  • Fix for createViewOrReplace #4856
  • SQLite: Fix foreign key constraints when altering a table #4189
  • MySQL: Validate connection fix #4794
  • MySQL: Set comment size warning limit to 1024 #4867

Typings:

... (truncated)

Changelog

Sourced from knex's changelog.

1.0.2 - 02 February, 2022

New features:

  • Support of MATERIALIZED and NOT MATERIALIZED with WITH/CTE #4940
  • Add raw support in onConflict clause #4960
  • Alter nullable constraint when alterNullable is set to true #4730
  • Add alterType parameter for alter function #4967
  • Support string json in json values #4988
  • MySQL: add with clause #4508

Bug fixes:

  • Fix error message for missing migration files #4937
  • Move deferrable to after on update/on delete #4976
  • Do not use sys.tables to find if a table exists #2328
  • PostgreSQL: Fix Order nulls #4989
  • MySQL: Fix collation when renaming column #2666
  • SQLite: Same boolean handling in better-sqlite3 as in sqlite3 #4982

Typings:

  • WhereILike - fix typo #4941

1.0.1 - 16 January, 2022

Bug fixes:

  • Fix package.json metadata

1.0.0 - 16 January, 2022

Breaking changes

  • Dropped support for Node 10;
  • Replaced unsupported sqlite3 driver with @vscode/sqlite3;
  • Changed data structure from RETURNING operation to be consistent with SELECT;
  • Changed Migrator to return list of migrations as objects consistently.

New features:

  • Support fromRaw #4781
  • Support zero precision in timestamp/datetime #4784
  • Support whereLike and whereILike #4779
  • Add JSDoc (TS flavor) to stub files #4809
  • Allow skip binding in limit and offset #4811
  • Support creating a new table in the database based on another table #4821
  • Accept Raw on onIn joins #4830
  • Implement support for custom seed sources #4842
  • Add binary uuid option #4836

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from nasquasha and a team as code owners February 4, 2022 04:22
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 4, 2022
@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2022

🦋 Changeset detected

Latest commit: 1dd5a02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@backstage/backend-common Patch
@backstage/backend-tasks Patch
@backstage/backend-test-utils Patch
@backstage/plugin-app-backend Patch
@backstage/plugin-auth-backend Patch
@backstage/plugin-bazaar-backend Patch
@backstage/plugin-catalog-backend Patch
@backstage/plugin-code-coverage-backend Patch
@backstage/plugin-scaffolder-backend Patch
@backstage/plugin-search-backend-module-pg Patch
@backstage/plugin-tech-insights-backend Patch
@backstage/plugin-techdocs-backend Patch
@backstage/create-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added awaiting-review auth area:catalog Related to the Catalog Project Area area:techdocs Related to the TechDocs Project Area area:scaffolder Everything and all things related to the scaffolder project area search Things related to Search labels Feb 4, 2022
@freben
Copy link
Member

freben commented Feb 4, 2022

Added a commit on top, to fix the tsc differences and updating to the correct sqlite package. I have some concerns though - will https://github.com/mapbox/node-sqlite3 be problematic for M1 or in general ARM arch users?

@freben freben force-pushed the dependabot/npm_and_yarn/knex-1.0.2 branch from d799130 to 797411d Compare February 4, 2022 10:15
@jhaals
Copy link
Member

jhaals commented Feb 4, 2022

M1 certified ✅

@freben freben force-pushed the dependabot/npm_and_yarn/knex-1.0.2 branch from 797411d to ce6a5e7 Compare February 4, 2022 10:42
Copy link
Member

@jhaals jhaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freben freben added this to Review in progress in Mammalian Mathematician Feb 7, 2022
dependabot bot and others added 2 commits February 7, 2022 15:51
Bumps [knex](https://github.com/knex/knex) from 0.95.6 to 1.0.2.
- [Release notes](https://github.com/knex/knex/releases)
- [Changelog](https://github.com/knex/knex/blob/master/CHANGELOG.md)
- [Commits](https://github.com/knex/knex/commits)

---
updated-dependencies:
- dependency-name: knex
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
@freben freben force-pushed the dependabot/npm_and_yarn/knex-1.0.2 branch from ce6a5e7 to 1dd5a02 Compare February 7, 2022 14:52
@freben freben merged commit cdc4282 into master Feb 8, 2022
Mammalian Mathematician automation moved this from Review in progress to Done Feb 8, 2022
@freben freben deleted the dependabot/npm_and_yarn/knex-1.0.2 branch February 8, 2022 16:05
@dschwank
Copy link
Contributor

dschwank commented Mar 2, 2022

The @vscode/sqlite3 dependency is not really ideal as it is not shipped with any binaries. The result is a more complex build process with either ...

  • having additional compilers & deps in the prod build (bigger images, security issues) or
  • having additional stages in the multi-stage build (more complex builds).

Next to that, @vscode/sqlite3 is "currently" only an intermediate solution and they tend to remove the repo as soon as their adjustments are merged.

I noticed that you @benjdlambert added in knex/knex#4871 the better-sqlite3 driver to the knex project - do you see any blockers why we can't move over to better-sqlite3 and drop @vscode/sqlite3? Or can you share some thoughts on the future plans regarding the @vscode/sqlite3 dependency?

/cc @freben

@Rugvip
Copy link
Member

Rugvip commented Mar 2, 2022

@dschwank yep you've arrived at the same conclusion and will be exploring moving over to better-sqlite3

@dschwank
Copy link
Contributor

dschwank commented Mar 2, 2022

That's nice @Rugvip ! Have you already started with the exploration? Let us know when we can support you with that! 👍

@jhaals
Copy link
Member

jhaals commented Mar 2, 2022

@dschwank it would be amazing if you could help out looking at this! We have not done more than realised that @vscode/sqlite3 have been very problematic and that we want to replace it with better-sqlite3. We are currently all hands on deck finishing the API stabilisation work before our 1.0 release.

@Rugvip
Copy link
Member

Rugvip commented Mar 2, 2022

Created #9912 so that we can continue the discussion there instead

@dschwank
Copy link
Contributor

dschwank commented Mar 3, 2022

Thanks @Rugvip 👍 We added a spike ticket to our backlog, not sure when we will have a look at it. We will check & post within your issue in case we start working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:catalog Related to the Catalog Project Area area:scaffolder Everything and all things related to the scaffolder project area area:techdocs Related to the TechDocs Project Area auth dependencies Pull requests that update a dependency file search Things related to Search
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants