New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch us over to better-sqlite3 #10132
Conversation
🦋 Changeset detectedLatest commit: efc73db The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Fixes #9912 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 😁
And it's totally possible to keep using @vscode/sqlite3
if desired right? This is just switching over defaults and docs. Ofc we'll stop testing it but thinking migration-wise it's not a hard requirement to move immediately on upgrade.
Any sense of performance difference?
Yeah both should continue working. But you'll see that I've even changed the string in places where it technically doesn't matter much, because I wanted to be consistent and discourage its use :) No real benchmarking done, no. Just functionally testing it. Would have to set up a larger test bed to measure performance differences. ... We should totally have one, built in in the repo. |
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
@vscode/sqlite3
works, but has proved troublesome in that it needs build infra to install. This has led to a lot of windows CI woes and bloated Docker images that now need python and gcc, and similar. Let's try outbetter-sqlite3
instead.This PR does NOT address updating dockerfiles and similar. Let's do that after we've proven that this works well.