Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch us over to better-sqlite3 #10132

Merged
merged 1 commit into from Mar 11, 2022
Merged

switch us over to better-sqlite3 #10132

merged 1 commit into from Mar 11, 2022

Conversation

freben
Copy link
Member

@freben freben commented Mar 11, 2022

@vscode/sqlite3 works, but has proved troublesome in that it needs build infra to install. This has led to a lot of windows CI woes and bloated Docker images that now need python and gcc, and similar. Let's try out better-sqlite3 instead.

This PR does NOT address updating dockerfiles and similar. Let's do that after we've proven that this works well.

@freben freben requested review from a team and nasquasha as code owners March 11, 2022 13:15
@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2022

🦋 Changeset detected

Latest commit: efc73db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@backstage/backend-common Patch
@backstage/backend-tasks Patch
@backstage/backend-test-utils Patch
@backstage/plugin-auth-backend Patch
@backstage/plugin-bazaar-backend Patch
@backstage/plugin-catalog-backend Patch
@backstage/plugin-code-coverage-backend Patch
@backstage/plugin-config-schema Patch
@backstage/plugin-scaffolder-backend Patch
@backstage/create-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added awaiting-review auth area:catalog Related to the Catalog Project Area documentation Improvements or additions to documentation area:scaffolder Everything and all things related to the scaffolder project area labels Mar 11, 2022
@Rugvip
Copy link
Member

Rugvip commented Mar 11, 2022

Fixes #9912 😁

@Rugvip Rugvip linked an issue Mar 11, 2022 that may be closed by this pull request
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😁

And it's totally possible to keep using @vscode/sqlite3 if desired right? This is just switching over defaults and docs. Ofc we'll stop testing it but thinking migration-wise it's not a hard requirement to move immediately on upgrade.

Any sense of performance difference?

@freben
Copy link
Member Author

freben commented Mar 11, 2022

Yeah both should continue working. But you'll see that I've even changed the string in places where it technically doesn't matter much, because I wanted to be consistent and discourage its use :)

No real benchmarking done, no. Just functionally testing it. Would have to set up a larger test bed to measure performance differences. ... We should totally have one, built in in the repo.

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:catalog Related to the Catalog Project Area area:scaffolder Everything and all things related to the scaffolder project area auth documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate sqlite driver switch to better-sqlite3
2 participants