fix: correctly handle issue with no label

balazsorban44 · Feb 12, 2024 · 578a391 · 578a391
1 parent af6911b
commit 578a391
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -17,7 +17,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Nissuer
-        uses: balazsorban44/nissuer@1.9.0
+        uses: balazsorban44/nissuer@1.9.1
         with:
           label-area-section: 'Which area\(s\) are affected\?(.*)'
           reproduction-issue-labels: "bug,"
diff --git a/README.md b/README.md
@@ -78,7 +78,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Nissuer
-        uses: balazsorban44/nissuer@1.9.0
+        uses: balazsorban44/nissuer@1.9.1
 ```
 
 Add a comment file (by default we look for `.github/invalid-reproduction.md`):

diff --git a/dist/index.js b/dist/index.js
diff --git a/index.js b/index.js
@@ -81,11 +81,14 @@ async function checkValidReproduction() {
   /** @type {string[]} */
   const labels = issue.labels.map((l) => l.name)
 
-  if (
-    (!labels.length && config.invalidLink.bugLabels.includes("")) ||
-    (config.invalidLink.bugLabels.length &&
-      !labels.some((l) => config.invalidLink.bugLabels.includes(l)))
-  )
+  const issueWithoutLabel =
+    config.invalidLink.bugLabels.includes("") && !labels.length
+
+  const issueMatchingLabel =
+    config.invalidLink.bugLabels.length &&
+    !labels.some((l) => config.invalidLink.bugLabels.includes(l))
+
+  if (!issueWithoutLabel || issueMatchingLabel)
     return info("Not manually or already labeled")
 
   if (await isValidReproduction(issue.body))