Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kinds and stmt #1613

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Fix kinds and stmt #1613

merged 3 commits into from
Sep 22, 2023

Conversation

birunts
Copy link
Contributor

@birunts birunts commented Aug 17, 2023

What type of PR is this?
Bug fix

What package or component does this PR mostly affect?
internal/language
rule
tests

What does this PR do? Why is it needed?
Bazel allows to pack rules or macros within a struct, e.g. convenience interfaces for select()
(see https://github.com/bazelbuild/bazel-skylib/blob/main/lib/selects.bzl)

Generated rule of selects.config_setting_group by rule.NewRule() is different with the rule parsed from the input file i.e. ruleFromExpr() in a way of different kind and identifier when fixing loads (FixLoads()).

Newly generated rule:

r := rule.NewRule("selects.config_setting_group", "config_group_name")

together with loads:

var loads = []rule.LoadInfo{
	{
		Name: "@bazel_skylib//lib:selects.bzl",
		Symbols: []string{
			"selects",
		},
	},
}

should produce in the BUILD.bazel output::

load("@bazel_skylib//lib:selects.bzl", "selects")

selects.config_setting_group(
    name = "config_group_name",
    ...
)

Which issues(s) does this PR fix?

Fixes #1612

Other notes for review

@birunts birunts force-pushed the fix_kinds_and_stmt branch 2 times, most recently from 02e2418 to b6848e9 Compare August 17, 2023 21:01
birunts added a commit to ARM-software/bob-build that referenced this pull request Aug 22, 2023
@birunts
fix: correct rule's kind & stmt
0a58c73 
Applies patch of Gazelle PR #1613
which is not merged yet.

This change unifies kinds for two ways of
creating rules and correctly sets the identifier
while fixing loads (`FixLoads()`).

bazelbuild/bazel-gazelle#1613

Signed-off-by: Sebastian Birunt <sebastian.birunt@arm.com>
Change-Id: Iec5ba6dfdec5d90722684b299844184d974a29e7
birunts added a commit to ARM-software/bob-build that referenced this pull request Aug 22, 2023
@birunts
fix: correct rule's kind & stmt
30a1f37 
Applies patch of Gazelle PR #1613
which is not merged yet.

This change unifies kinds for two ways of
creating rules and correctly sets the identifier
while fixing loads (`FixLoads()`).

bazelbuild/bazel-gazelle#1613

Signed-off-by: Sebastian Birunt <sebastian.birunt@arm.com>
Change-Id: Iec5ba6dfdec5d90722684b299844184d974a29e7
@birunts birunts mentioned this pull request Aug 22, 2023
Merged
lukokr-aarch64 pushed a commit to ARM-software/bob-build that referenced this pull request Aug 22, 2023
@birunts @lukokr-aarch64
fix: correct rule's kind & stmt
722bfb4 
Applies patch of Gazelle PR #1613
which is not merged yet.

This change unifies kinds for two ways of
creating rules and correctly sets the identifier
while fixing loads (`FixLoads()`).

bazelbuild/bazel-gazelle#1613

Signed-off-by: Sebastian Birunt <sebastian.birunt@arm.com>
Change-Id: Iec5ba6dfdec5d90722684b299844184d974a29e7
fmeum
fmeum reviewed Aug 28, 2023
View reviewed changes
rule/rule.go Outdated Show resolved Hide resolved
@birunts birunts force-pushed the fix_kinds_and_stmt branch 3 times, most recently from efe4aa6 to dce3790 Compare September 8, 2023 11:48
fmeum
fmeum approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@fmeum fmeum left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, with one more comment.

Please mention me after making your changes as I don't get notifications for pushes on PRs.

rule/rule.go Outdated Show resolved Hide resolved
fmeum
fmeum reviewed Sep 21, 2023
View reviewed changes
rule/rule.go Outdated Show resolved Hide resolved
@birunts
fix: correct rule's kind & stmt
5daafd9 
Created rule with `NewRule()` is different
to the rule created with `ruleFromExpr()`
(when parsing input data).

In the first case (`NewRule()`) kind is set to
`build.Ident{Name: string}` while it's parsed
expression in the second case (`ruleFromExpr()`).

For rules packed in a struct like
`selects.config_setting_group` there is no way
to create/generate the same rule as the one
parsed from the file as both will have
different kinds.

This change unifies kinds for two ways of
creating rules and correctly sets the identifier
while fixing loads (`FixLoads()`).
@birunts
chore: fix load tests
535d902 
Change adds test to verify fixing load
statements while generating packed rules
in struct e.g. `selects.config_setting_group`.
@birunts
chore: update MODULE.bazel.lock
5e99d90
fmeum
fmeum approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@fmeum fmeum enabled auto-merge (squash) September 22, 2023 21:03
@fmeum fmeum merged commit 2090e57 into bazelbuild:master Sep 22, 2023
10 checks passed
renovate bot added a commit to kreempuff/rules_unreal_engine that referenced this pull request Nov 8, 2023
@renovate
chore(deps): update dependency bazel_gazelle to v0.34.0 (#50)
5ab614a 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | minor | `v0.33.0` -> `v0.34.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary>

###
[`v0.34.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.34.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.33.0...v0.34.0)

#### What's Changed

- update readme for v0.33.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1627
- Remove golang.org/x/crypto dep by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1631
- Fix map_kind with empty rules by
[@&#8203;lbcjbb](https://togithub.com/lbcjbb) in
[bazelbuild/bazel-gazelle#1441
- fix: add missing bzl_library declaration and dep by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[bazelbuild/bazel-gazelle#1633
- chore: add bzl_test to ensure that bzl_library declarations exist by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[bazelbuild/bazel-gazelle#1634
- Set runfiles environment variables for Gazelle by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1632
- address comments from
[#&#8203;1597](https://togithub.com/bazelbuild/bazel-gazelle/issues/1597)
by [@&#8203;shahms](https://togithub.com/shahms) in
[bazelbuild/bazel-gazelle#1628
- Fix kinds and stmt by [@&#8203;birunts](https://togithub.com/birunts)
in
[bazelbuild/bazel-gazelle#1613
- Export workspace file in go_repository_config.bzl by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1641
- Add github.com/google/gnostic-models to default_gazelle_overrides.bzl
by [@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1645
- Support parsing labels that begin '@&#8203;@&#8203;' by
[@&#8203;mark-thm](https://togithub.com/mark-thm) in
[bazelbuild/bazel-gazelle#1651
- Fix path for google/gnostic-models by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1652
- fix(bzlmod): allow passing build_extra_args in gazelle_override by
[@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) in
[bazelbuild/bazel-gazelle#1648
- prepare release 0.34.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1656

#### New Contributors

- [@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) made
their first contribution in
[bazelbuild/bazel-gazelle#1648

**Full Changelog**:
bazelbuild/bazel-gazelle@v0.33.0...v0.34.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kreempuff/rules_unreal_engine).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
cgrindel-self-hosted-renovate bot added a commit to cgrindel/bazel-starlib that referenced this pull request Nov 8, 2023
@cgrindel-self-hosted-renovate
chore(deps): update dependency bazel_gazelle to v0.34.0 (#365)
32880f4 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | minor | `v0.33.0` -> `v0.34.0` |

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary>

###
[`v0.34.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.34.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.33.0...v0.34.0)

#### What's Changed

- update readme for v0.33.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1627
- Remove golang.org/x/crypto dep by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1631
- Fix map_kind with empty rules by
[@&#8203;lbcjbb](https://togithub.com/lbcjbb) in
[bazelbuild/bazel-gazelle#1441
- fix: add missing bzl_library declaration and dep by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[bazelbuild/bazel-gazelle#1633
- chore: add bzl_test to ensure that bzl_library declarations exist by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[bazelbuild/bazel-gazelle#1634
- Set runfiles environment variables for Gazelle by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1632
- address comments from
[#&#8203;1597](https://togithub.com/bazelbuild/bazel-gazelle/issues/1597)
by [@&#8203;shahms](https://togithub.com/shahms) in
[bazelbuild/bazel-gazelle#1628
- Fix kinds and stmt by [@&#8203;birunts](https://togithub.com/birunts)
in
[bazelbuild/bazel-gazelle#1613
- Export workspace file in go_repository_config.bzl by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1641
- Add github.com/google/gnostic-models to default_gazelle_overrides.bzl
by [@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1645
- Support parsing labels that begin '@&#8203;@&#8203;' by
[@&#8203;mark-thm](https://togithub.com/mark-thm) in
[bazelbuild/bazel-gazelle#1651
- Fix path for google/gnostic-models by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1652
- fix(bzlmod): allow passing build_extra_args in gazelle_override by
[@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) in
[bazelbuild/bazel-gazelle#1648
- prepare release 0.34.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1656

#### New Contributors

- [@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) made
their first contribution in
[bazelbuild/bazel-gazelle#1648

**Full Changelog**:
bazelbuild/bazel-gazelle@v0.33.0...v0.34.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
alexeagle pushed a commit to aspect-build/rules_py that referenced this pull request Nov 14, 2023
@renovate
chore(deps): update dependency bazel_gazelle to v0.34.0 (#188)
e613fe5 
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | minor | `v0.32.0` -> `v0.34.0` |

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary>

###
[`v0.34.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.34.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.33.0...v0.34.0)

#### What's Changed

- update readme for v0.33.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1627
- Remove golang.org/x/crypto dep by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1631
- Fix map_kind with empty rules by
[@&#8203;lbcjbb](https://togithub.com/lbcjbb) in
[bazelbuild/bazel-gazelle#1441
- fix: add missing bzl_library declaration and dep by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[bazelbuild/bazel-gazelle#1633
- chore: add bzl_test to ensure that bzl_library declarations exist by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[bazelbuild/bazel-gazelle#1634
- Set runfiles environment variables for Gazelle by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1632
- address comments from
[#&#8203;1597](https://togithub.com/bazelbuild/bazel-gazelle/issues/1597)
by [@&#8203;shahms](https://togithub.com/shahms) in
[bazelbuild/bazel-gazelle#1628
- Fix kinds and stmt by [@&#8203;birunts](https://togithub.com/birunts)
in
[bazelbuild/bazel-gazelle#1613
- Export workspace file in go_repository_config.bzl by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1641
- Add github.com/google/gnostic-models to default_gazelle_overrides.bzl
by [@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1645
- Support parsing labels that begin '@&#8203;@&#8203;' by
[@&#8203;mark-thm](https://togithub.com/mark-thm) in
[bazelbuild/bazel-gazelle#1651
- Fix path for google/gnostic-models by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1652
- fix(bzlmod): allow passing build_extra_args in gazelle_override by
[@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) in
[bazelbuild/bazel-gazelle#1648
- prepare release 0.34.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1656

#### New Contributors

- [@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) made
their first contribution in
[bazelbuild/bazel-gazelle#1648

**Full Changelog**:
bazelbuild/bazel-gazelle@v0.33.0...v0.34.0

###
[`v0.33.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.33.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.32.0...v0.33.0)

#### What's Changed

- Generate BUILD files for grpc-gateway by default by
[@&#8203;seh](https://togithub.com/seh) in
[bazelbuild/bazel-gazelle#1578
- Remove temporary workaround after rules_go 0.41.0 release by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1577
- bzlmod: Use first host-compatible SDK to bootstrap Gazelle by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1581
- Update: golang.org/x/exp & golang.org/x/oauth2 deps. by
[@&#8203;sfc-gh-ptabor](https://togithub.com/sfc-gh-ptabor) in
[bazelbuild/bazel-gazelle#1582
- \[README.rst] Mention kotlin PoC by
[@&#8203;kolloch](https://togithub.com/kolloch) in
[bazelbuild/bazel-gazelle#1590
- Fix and let `# gazelle:follow` accept a glob by
[@&#8203;shahms](https://togithub.com/shahms) in
[bazelbuild/bazel-gazelle#1596
- Add support for isolated `go_deps` usages by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1584
- feat(bzlmod): support archive_override in go_deps by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1559
- fix: avoid updating `WORKSPACE` file when running `update-repos` when
bzlmod is enabled by [@&#8203;cgrindel](https://togithub.com/cgrindel)
in
[bazelbuild/bazel-gazelle#1589
- Make `go_deps.from_file` compatible with Go 1.21 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1605
- go_repository: fix missing default GOPROXY by
[@&#8203;sluongng](https://togithub.com/sluongng) in
[bazelbuild/bazel-gazelle#1602
- fix: patch support for dir named workspace by
[@&#8203;michaellzc](https://togithub.com/michaellzc) in
[bazelbuild/bazel-gazelle#1606
- Revert "go_repository: fix missing default GOPROXY
([#&#8203;1602](https://togithub.com/bazelbuild/bazel-gazelle/issues/1602))"
by [@&#8203;sluongng](https://togithub.com/sluongng) in
[bazelbuild/bazel-gazelle#1609
- Upgrade `golang.org/x/mod` Vendor to Support Go 1.21 by
[@&#8203;alan910127](https://togithub.com/alan910127) in
[bazelbuild/bazel-gazelle#1611
- fix: go_repository: never shadow a module with a compatibility mapping
for major versions. by [@&#8203;reltuk](https://togithub.com/reltuk) in
[bazelbuild/bazel-gazelle#1608
- bug fix: don't generate invalid go_binary rules for empty main
packages by [@&#8203;andyscott](https://togithub.com/andyscott) in
[bazelbuild/bazel-gazelle#1618
- Fix wrong Kotlin Support link in README. by
[@&#8203;duckladydinh](https://togithub.com/duckladydinh) in
[bazelbuild/bazel-gazelle#1619
- bzlmod: Verify that the lockfile is platform-independent by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1617
- Add gazelle_rust under supported languages by
[@&#8203;Calsign](https://togithub.com/Calsign) in
[bazelbuild/bazel-gazelle#1620
- replace golang.org/x/tools with
golang.org/x/tools/go/vcs@v0.1.0-deprecated by
[@&#8203;malt3](https://togithub.com/malt3) in
[bazelbuild/bazel-gazelle#1603
- Implement Merger interface by
[@&#8203;Whoaa512](https://togithub.com/Whoaa512) in
[bazelbuild/bazel-gazelle#1569
- Improve Gazelle launcher's runfiles discovery on Windows by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1604
- Add an entry for "github.com/googleapis/gax-go/v2" to
default_gazelle_overrides.bzl by
[@&#8203;andrewmbenton](https://togithub.com/andrewmbenton) in
[bazelbuild/bazel-gazelle#1623
- add a go_test directive to enable generating go_test targets per
\_test.go file by [@&#8203;shahms](https://togithub.com/shahms) in
[bazelbuild/bazel-gazelle#1597
- Detect whether Gazelle itself is a Bazel module by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1624
- prepare release 0.33 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1615

#### New Contributors

- [@&#8203;sfc-gh-ptabor](https://togithub.com/sfc-gh-ptabor) made their
first contribution in
[bazelbuild/bazel-gazelle#1582
- [@&#8203;kolloch](https://togithub.com/kolloch) made their first
contribution in
[bazelbuild/bazel-gazelle#1590
- [@&#8203;shahms](https://togithub.com/shahms) made their first
contribution in
[bazelbuild/bazel-gazelle#1596
- [@&#8203;michaellzc](https://togithub.com/michaellzc) made their first
contribution in
[bazelbuild/bazel-gazelle#1606
- [@&#8203;alan910127](https://togithub.com/alan910127) made their first
contribution in
[bazelbuild/bazel-gazelle#1611
- [@&#8203;reltuk](https://togithub.com/reltuk) made their first
contribution in
[bazelbuild/bazel-gazelle#1608
- [@&#8203;andyscott](https://togithub.com/andyscott) made their first
contribution in
[bazelbuild/bazel-gazelle#1618
- [@&#8203;duckladydinh](https://togithub.com/duckladydinh) made their
first contribution in
[bazelbuild/bazel-gazelle#1619
- [@&#8203;Calsign](https://togithub.com/Calsign) made their first
contribution in
[bazelbuild/bazel-gazelle#1620
- [@&#8203;malt3](https://togithub.com/malt3) made their first
contribution in
[bazelbuild/bazel-gazelle#1603
- [@&#8203;andrewmbenton](https://togithub.com/andrewmbenton) made their
first contribution in
[bazelbuild/bazel-gazelle#1623

**Full Changelog**:
bazelbuild/bazel-gazelle@v0.32.0...v0.33.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/aspect-build/rules_py).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Nov 24, 2023
@cgrindel-self-hosted-renovate @cgrindel
fix(deps): update module github.com/bazelbuild/bazel-gazelle to v0.34…
ecfeba7 
….0 (#486)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/bazelbuild/bazel-gazelle](https://togithub.com/bazelbuild/bazel-gazelle)
| require | minor | `v0.33.0` -> `v0.34.0` |

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle
(github.com/bazelbuild/bazel-gazelle)</summary>

###
[`v0.34.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.34.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.33.0...v0.34.0)

#### What's Changed

- update readme for v0.33.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1627
- Remove golang.org/x/crypto dep by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1631
- Fix map_kind with empty rules by
[@&#8203;lbcjbb](https://togithub.com/lbcjbb) in
[bazelbuild/bazel-gazelle#1441
- fix: add missing bzl_library declaration and dep by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[bazelbuild/bazel-gazelle#1633
- chore: add bzl_test to ensure that bzl_library declarations exist by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[bazelbuild/bazel-gazelle#1634
- Set runfiles environment variables for Gazelle by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1632
- address comments from
[#&#8203;1597](https://togithub.com/bazelbuild/bazel-gazelle/issues/1597)
by [@&#8203;shahms](https://togithub.com/shahms) in
[bazelbuild/bazel-gazelle#1628
- Fix kinds and stmt by [@&#8203;birunts](https://togithub.com/birunts)
in
[bazelbuild/bazel-gazelle#1613
- Export workspace file in go_repository_config.bzl by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1641
- Add github.com/google/gnostic-models to default_gazelle_overrides.bzl
by [@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1645
- Support parsing labels that begin '@&#8203;@&#8203;' by
[@&#8203;mark-thm](https://togithub.com/mark-thm) in
[bazelbuild/bazel-gazelle#1651
- Fix path for google/gnostic-models by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1652
- fix(bzlmod): allow passing build_extra_args in gazelle_override by
[@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) in
[bazelbuild/bazel-gazelle#1648
- prepare release 0.34.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1656

#### New Contributors

- [@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) made
their first contribution in
[bazelbuild/bazel-gazelle#1648

**Full Changelog**:
bazelbuild/bazel-gazelle@v0.33.0...v0.34.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuMTAwLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

---------

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Co-authored-by: Chuck Grindel <chuck.grindel@gmail.com>
jeromep-stripe pushed a commit to jeromep-stripe/bazel-gazelle that referenced this pull request Mar 22, 2024
@birunts @jeromep-stripe
Fix kinds and stmt (bazelbuild#1613)
c95de8e 
* fix: correct rule's kind & stmt

Created rule with `NewRule()` is different
to the rule created with `ruleFromExpr()`
(when parsing input data).

In the first case (`NewRule()`) kind is set to
`build.Ident{Name: string}` while it's parsed
expression in the second case (`ruleFromExpr()`).

For rules packed in a struct like
`selects.config_setting_group` there is no way
to create/generate the same rule as the one
parsed from the file as both will have
different kinds.

This change unifies kinds for two ways of
creating rules and correctly sets the identifier
while fixing loads (`FixLoads()`).

* chore: fix load tests

Change adds test to verify fixing load
statements while generating packed rules
in struct e.g. `selects.config_setting_group`.

* chore: update MODULE.bazel.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mismatched rules kind & stmt
2 participants
@birunts @fmeum